third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp - Issue 2253643002: [DevTools] Copy objects from debugger context to inspected context properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 2253643002: [DevTools] Copy objects from debugger context to inspected context properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: copier Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

index f016ccc0219530f474ae7f2cf36033c173b212e7..782e5bbab014739c75726871ec7dc193b38f4843 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

@@ -42,6 +42,8 @@ v8::Local<v8::Object> V8InjectedScriptHost::create(v8::Local<v8::Context> contex

{

v8::Isolate* isolate = inspector->isolate();

v8::Local<v8::Object> injectedScriptHost = v8::Object::New(isolate);

+ bool success = injectedScriptHost->SetPrototype(context, v8::Null(isolate)).FromMaybe(false);

+ DCHECK(success);

v8::Local<v8::External> debuggerExternal = v8::External::New(isolate, inspector);

setFunctionProperty(context, injectedScriptHost, "internalConstructorName", V8InjectedScriptHost::internalConstructorNameCallback, debuggerExternal);

setFunctionProperty(context, injectedScriptHost, "formatAccessorsAsProperties", V8InjectedScriptHost::formatAccessorsAsProperties, debuggerExternal);