Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2253383002: [DevTools] Schema domain implementation. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Schema domain implementation. One can query domain names and versions. v8_inspector provides it's own implementation, while browser has a hardcoded list for now. BUG=635947, 635953 Committed: https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec Cr-Commit-Position: refs/heads/master@{#413561}

Patch Set 1 #

Total comments: 4

Patch Set 2 : schema #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -7 lines) Patch
A content/browser/devtools/protocol/schema_handler.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A content/browser/devtools/protocol/schema_handler.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 1 5 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 1 5 chunks +27 lines, -1 line 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/V8SchemaAgentImpl.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/V8SchemaAgentImpl.cpp View 1 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 1 1 chunk +29 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 4 chunks +14 lines, -3 lines 0 comments Download

Dependent Patchsets:

Issue 2572653003 Patch 1

Messages

Total messages: 19 (13 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-18 02:17:27 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2253383002/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right): https://codereview.chromium.org/2253383002/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json#newcode5 third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:5: "domain": "Meta", Schema https://codereview.chromium.org/2253383002/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json#newcode10 third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:10: "id": "DomainDescription", Domain
4 years, 4 months ago (2016-08-18 20:25:32 UTC) #7
dgozman
https://codereview.chromium.org/2253383002/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right): https://codereview.chromium.org/2253383002/diff/1/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json#newcode5 third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:5: "domain": "Meta", On 2016/08/18 20:25:32, pfeldman wrote: > Schema ...
4 years, 4 months ago (2016-08-22 15:52:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253383002/20001
4 years, 4 months ago (2016-08-22 19:46:23 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 22:43:49 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 22:48:21 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec
Cr-Commit-Position: refs/heads/master@{#413561}

Powered by Google App Engine
This is Rietveld 408576698