Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2253283003: macviews: reinstate close button (Closed)

Created:
4 years, 4 months ago by Elly Fong-Jones
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, groby+bubble_chromium.org, rouslan+bubble_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macviews: reinstate close button Blanket removal of close buttons turns out to have been hasty, since many of our dialogs are designed around having them, not just visually but semantically. For now, return the behavior to that of other platforms while we reconsider this UI design. BUG=637178 Committed: https://crrev.com/4aad4a8d18daf041d47bc0d9bb489f05bd5f5188 Cr-Commit-Position: refs/heads/master@{#413156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Elly Fong-Jones
msw: ptal? :)
4 years, 4 months ago (2016-08-18 15:46:36 UTC) #3
msw
lgtm
4 years, 4 months ago (2016-08-18 16:44:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253283003/1
4 years, 4 months ago (2016-08-18 17:35:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/276194)
4 years, 4 months ago (2016-08-18 19:33:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253283003/1
4 years, 4 months ago (2016-08-19 14:23:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 16:08:28 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 16:11:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4aad4a8d18daf041d47bc0d9bb489f05bd5f5188
Cr-Commit-Position: refs/heads/master@{#413156}

Powered by Google App Engine
This is Rietveld 408576698