ui/views/bubble/bubble_frame_view.cc - Issue 2253283003: macviews: reinstate close button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 2253283003: macviews: reinstate close button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_frame_view.cc

diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc

index c3714d537673ac730fd818390ec024af2c9aff6f..f03f984ef6e3d4854188cde0953b2cbff28353a0 100644

--- a/ui/views/bubble/bubble_frame_view.cc

+++ b/ui/views/bubble/bubble_frame_view.cc

@@ -211,12 +211,7 @@ void BubbleFrameView::GetWindowMask(const gfx::Size& size,

}

void BubbleFrameView::ResetWindowControls() {

-#if defined(OS_MACOSX)

- // On Mac, close buttons are never shown.

- close_->SetVisible(false);

-#else

close_->SetVisible(GetWidget()->widget_delegate()->ShouldShowCloseButton());

-#endif

}

void BubbleFrameView::UpdateWindowIcon() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »