Add llvm fuzzer for CPDF_PSEngine

Add llvm fuzzer for CPDF_PSEngine

Put class definition into its own header file so fuzzer can find it.

Fix a pair of div by 0s immediately hit by the fuzzer.

Committed: https://pdfium.googlesource.com/pdfium/+/7996fe888cb98597cd1608af05fb59f45c837fc6

[Tom Sepez, 2016-08-17 22:53:53]

Description was changed from

==========
Add llvm fuzzer for CPDF_PSEngine
==========

to

==========
Add llvm fuzzer for CPDF_PSEngine

Put class definition into its own header file so fuzzer can find it.

Fix a pair of div by 0s immediately hit by the fuzzer.
==========

[Tom Sepez, 2016-08-17 22:53:53]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-08-17 22:56:08]

Lei, for review.

[Lei Zhang, 2016-08-18 06:21:39]

lgtm

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_psengine.h (right):

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_psengine.h:10: #include <vector>
alphabetical order

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/fpdf_page_func.cpp (right):

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/fpdf_page_func.cpp:25: class CPDF_PSOP {
Would be nice to move these out to their own file as well.

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/fpdf_page_func.cpp:205: if (i2)
1 Push() with a ternary operator inside? Ditto for MOD.

https://codereview.chromium.org/2253193003/diff/20001/testing/libfuzzer/pdf_p...
File testing/libfuzzer/pdf_psengine_fuzzer.cc (right):

https://codereview.chromium.org/2253193003/diff/20001/testing/libfuzzer/pdf_p...
testing/libfuzzer/pdf_psengine_fuzzer.cc:11: if (engine.Parse((char*)data,
size))
reinterpret_cast<const char*>(data)

[Tom Sepez, 2016-08-18 21:23:07]

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_psengine.h (right):

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_psengine.h:10: #include <vector>
On 2016/08/18 06:21:39, Lei Zhang wrote:
> alphabetical order

Done.

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/fpdf_page_func.cpp (right):

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/fpdf_page_func.cpp:25: class CPDF_PSOP {
On 2016/08/18 06:21:39, Lei Zhang wrote:
> Would be nice to move these out to their own file as well.
Agreed, someday.

https://codereview.chromium.org/2253193003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/fpdf_page_func.cpp:205: if (i2)
On 2016/08/18 06:21:39, Lei Zhang wrote:
> 1 Push() with a ternary operator inside? Ditto for MOD.

Done.

https://codereview.chromium.org/2253193003/diff/20001/testing/libfuzzer/pdf_p...
File testing/libfuzzer/pdf_psengine_fuzzer.cc (right):

https://codereview.chromium.org/2253193003/diff/20001/testing/libfuzzer/pdf_p...
testing/libfuzzer/pdf_psengine_fuzzer.cc:11: if (engine.Parse((char*)data,
size))
On 2016/08/18 06:21:39, Lei Zhang wrote:
> reinterpret_cast<const char*>(data)

Done.

[Tom Sepez, 2016-08-18 21:24:04]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-08-18 21:24:04]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2253193003/#ps40001
(title: "Fix includes, ? operator, reinterpret cast.")

[commit-bot: I haz the power, 2016-08-18 21:24:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 21:37:10]

Description was changed from

==========
Add llvm fuzzer for CPDF_PSEngine

Put class definition into its own header file so fuzzer can find it.

Fix a pair of div by 0s immediately hit by the fuzzer.
==========

to

==========
Add llvm fuzzer for CPDF_PSEngine

Put class definition into its own header file so fuzzer can find it.

Fix a pair of div by 0s immediately hit by the fuzzer.

Committed:
https://pdfium.googlesource.com/pdfium/+/7996fe888cb98597cd1608af05fb59f45c83...
==========

[commit-bot: I haz the power, 2016-08-18 21:37:11]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/7996fe888cb98597cd1608af05fb59f45c83...