Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2253173002: Remove callbacks for SurfaceFactoryOzone::LoadEGLGLES2Bindings(). (Closed)

Created:
4 years, 4 months ago by kylechar
Modified:
4 years, 4 months ago
Reviewers:
rjkroege, halliwell
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove callbacks for SurfaceFactoryOzone::LoadEGLGLES2Bindings(). Functions defined in //ui/gl originally had to be provided as callbacks due to dependency problems. This is no longer necessary, so switch Ozone implementations to call functions directly. BUG=611142 Committed: https://crrev.com/ef99f26bfbb364be711a0c7ddf301df1951277ec Cr-Commit-Position: refs/heads/master@{#412931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -90 lines) Patch
M ui/gl/init/gl_initializer_ozone.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/ozone/common/egl_util.h View 1 chunk +2 lines, -8 lines 0 comments Download
M ui/ozone/common/egl_util.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.cc View 2 chunks +1 line, -8 lines 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/ozone/platform/headless/headless_surface_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/ozone/platform/headless/headless_surface_factory.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 2 chunks +2 lines, -10 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
kylechar
rjkroege for ui/ozone/* and general review. halliwell for ui/ozone/platform/cast/*.
4 years, 4 months ago (2016-08-17 18:50:20 UTC) #6
halliwell
On 2016/08/17 18:50:20, kylechar wrote: > rjkroege for ui/ozone/* and general review. > halliwell for ...
4 years, 4 months ago (2016-08-17 19:59:17 UTC) #7
rjkroege
lgtm
4 years, 4 months ago (2016-08-18 19:18:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253173002/1
4 years, 4 months ago (2016-08-18 20:35:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 21:22:59 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 21:26:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef99f26bfbb364be711a0c7ddf301df1951277ec
Cr-Commit-Position: refs/heads/master@{#412931}

Powered by Google App Engine
This is Rietveld 408576698