Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2253163002: Minor refactoring: Move set-up of host and port into update_w3c_test_expectations.py. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor refactoring: Move set-up of host and port into update_w3c_test_expectations.py. Reason: I can't see any particular reason why the port needs to be gotten in the wrapper script, and this change simplifies the wrapper script. Committed: https://crrev.com/09cadea5a9a4ebf1a367237093d108db7c2f7da1 Cr-Commit-Position: refs/heads/master@{#412737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/Tools/Scripts/update-w3c-test-expectations View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
qyearsley
4 years, 4 months ago (2016-08-17 18:31:32 UTC) #3
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-17 22:24:47 UTC) #4
Dirk Pranke
On a side note, we don't really need the SCMDetection stuff any more, since we ...
4 years, 4 months ago (2016-08-17 22:28:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253163002/1
4 years, 4 months ago (2016-08-17 22:52:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 04:04:23 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 04:06:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09cadea5a9a4ebf1a367237093d108db7c2f7da1
Cr-Commit-Position: refs/heads/master@{#412737}

Powered by Google App Engine
This is Rietveld 408576698