Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2253143002: Revert of cc: Move data to LayerTree from LayerTreeHost. (Closed)

Created:
4 years, 4 months ago by Reid Kleckner
Modified:
4 years, 4 months ago
CC:
blink-reviews, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, krasin1, pcc1
Base URL:
https://chromium.googlesource.com/chromium/src.git@layer_tree_change
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ ) Reason for revert: Invalid cast breaks CFI build, which is shipping on Linux soon Original issue's description: > cc: Move data to LayerTree from LayerTreeHost. > > Move bulk of the tree state from LayerTreeHost to LayerTree. The > LayerTree mirrors LayerTreeImpl in terms of what it stores and is used > to push the corresponding properties to LayerTreeImpl during commit. > > BUG=628683 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b > Cr-Commit-Position: refs/heads/master@{#412413} TBR=enne@chromium.org,loyso@chromium.org,vollick@chromium.org,piman@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=628683 Committed: https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e Cr-Commit-Position: refs/heads/master@{#412569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1492 lines, -1633 lines) Patch
M cc/debug/invalidation_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_unittest.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M cc/layers/layer.cc View 30 chunks +40 lines, -38 lines 0 comments Download
M cc/layers/layer_position_constraint_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/layers/layer_proto_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_unittest.cc View 49 chunks +86 lines, -95 lines 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_unittest.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 18 chunks +19 lines, -20 lines 0 comments Download
M cc/layers/surface_layer_unittest.cc View 8 chunks +8 lines, -10 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 12 chunks +15 lines, -18 lines 0 comments Download
M cc/output/delegating_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/proto/layer_tree.proto View 1 chunk +0 lines, -30 lines 0 comments Download
M cc/proto/layer_tree_host.proto View 2 chunks +29 lines, -1 line 0 comments Download
M cc/test/fake_layer_tree_host.h View 1 chunk +3 lines, -7 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 2 chunks +7 lines, -30 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M cc/trees/layer_tree.h View 3 chunks +6 lines, -164 lines 0 comments Download
M cc/trees/layer_tree.cc View 2 chunks +9 lines, -459 lines 0 comments Download
M cc/trees/layer_tree_host.h View 13 chunks +117 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 33 chunks +457 lines, -93 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 6 chunks +15 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_readback.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 91 chunks +235 lines, -188 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 28 chunks +49 lines, -48 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 19 chunks +20 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_damage.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_occlusion.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_picture.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 23 chunks +68 lines, -54 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_serialization.cc View 7 chunks +137 lines, -149 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_video.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/tree_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 13 chunks +25 lines, -25 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M ui/compositor/compositor.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Reid Kleckner
Created Revert of cc: Move data to LayerTree from LayerTreeHost.
4 years, 4 months ago (2016-08-17 17:07:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253143002/1
4 years, 4 months ago (2016-08-17 17:08:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 17:11:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2f03c7f2b75275f951efaf6b5e5f61cc52d74a8e Cr-Commit-Position: refs/heads/master@{#412569}
4 years, 4 months ago (2016-08-17 17:15:19 UTC) #7
krasin
4 years, 4 months ago (2016-08-17 18:10:53 UTC) #9
Message was sent while issue was closed.
Thank you for spotting and reverting this, Reid!

Powered by Google App Engine
This is Rietveld 408576698