Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Side by Side Diff: cc/layers/surface_layer_unittest.cc

Issue 2253143002: Revert of cc: Move data to LayerTree from LayerTreeHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layer_tree_change
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | cc/layers/texture_layer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 15 matching lines...) Expand all
26 namespace cc { 26 namespace cc {
27 namespace { 27 namespace {
28 28
29 static constexpr uint32_t kArbitraryClientId = 0; 29 static constexpr uint32_t kArbitraryClientId = 0;
30 30
31 class SurfaceLayerTest : public testing::Test { 31 class SurfaceLayerTest : public testing::Test {
32 protected: 32 protected:
33 void SetUp() override { 33 void SetUp() override {
34 layer_tree_host_ = 34 layer_tree_host_ =
35 FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_); 35 FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_);
36 layer_tree_ = layer_tree_host_->GetLayerTree(); 36 layer_tree_host_->SetViewportSize(gfx::Size(10, 10));
37 layer_tree_->SetViewportSize(gfx::Size(10, 10));
38 } 37 }
39 38
40 void TearDown() override { 39 void TearDown() override {
41 if (layer_tree_host_) { 40 if (layer_tree_host_) {
42 layer_tree_->SetRootLayer(nullptr); 41 layer_tree_host_->SetRootLayer(nullptr);
43 layer_tree_host_ = nullptr; 42 layer_tree_host_ = nullptr;
44 } 43 }
45 } 44 }
46 45
47 FakeLayerTreeHostClient fake_client_; 46 FakeLayerTreeHostClient fake_client_;
48 TestTaskGraphRunner task_graph_runner_; 47 TestTaskGraphRunner task_graph_runner_;
49 std::unique_ptr<FakeLayerTreeHost> layer_tree_host_; 48 std::unique_ptr<FakeLayerTreeHost> layer_tree_host_;
50 LayerTree* layer_tree_;
51 }; 49 };
52 50
53 void SatisfyCallback(SurfaceSequence* out, const SurfaceSequence& in) { 51 void SatisfyCallback(SurfaceSequence* out, const SurfaceSequence& in) {
54 *out = in; 52 *out = in;
55 } 53 }
56 54
57 void RequireCallback(SurfaceId* out_id, 55 void RequireCallback(SurfaceId* out_id,
58 std::set<SurfaceSequence>* out, 56 std::set<SurfaceSequence>* out,
59 const SurfaceId& in_id, 57 const SurfaceId& in_id,
60 const SurfaceSequence& in) { 58 const SurfaceSequence& in) {
61 *out_id = in_id; 59 *out_id = in_id;
62 out->insert(in); 60 out->insert(in);
63 } 61 }
64 62
65 // Check that one surface can be referenced by multiple LayerTreeHosts, and 63 // Check that one surface can be referenced by multiple LayerTreeHosts, and
66 // each will create its own SurfaceSequence that's satisfied on destruction. 64 // each will create its own SurfaceSequence that's satisfied on destruction.
67 TEST_F(SurfaceLayerTest, MultipleFramesOneSurface) { 65 TEST_F(SurfaceLayerTest, MultipleFramesOneSurface) {
68 SurfaceSequence blank_change; // Receives sequence if commit doesn't happen. 66 SurfaceSequence blank_change; // Receives sequence if commit doesn't happen.
69 67
70 SurfaceId required_id; 68 SurfaceId required_id;
71 std::set<SurfaceSequence> required_seq; 69 std::set<SurfaceSequence> required_seq;
72 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create( 70 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create(
73 base::Bind(&SatisfyCallback, &blank_change), 71 base::Bind(&SatisfyCallback, &blank_change),
74 base::Bind(&RequireCallback, &required_id, &required_seq))); 72 base::Bind(&RequireCallback, &required_id, &required_seq)));
75 layer->SetSurfaceId(SurfaceId(kArbitraryClientId, 1, 0), 1.f, 73 layer->SetSurfaceId(SurfaceId(kArbitraryClientId, 1, 0), 1.f,
76 gfx::Size(1, 1)); 74 gfx::Size(1, 1));
77 layer_tree_host_->set_surface_client_id(1); 75 layer_tree_host_->set_surface_client_id(1);
78 layer_tree_->SetRootLayer(layer); 76 layer_tree_host_->SetRootLayer(layer);
79 77
80 std::unique_ptr<FakeLayerTreeHost> layer_tree_host2 = 78 std::unique_ptr<FakeLayerTreeHost> layer_tree_host2 =
81 FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_); 79 FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_);
82 scoped_refptr<SurfaceLayer> layer2(SurfaceLayer::Create( 80 scoped_refptr<SurfaceLayer> layer2(SurfaceLayer::Create(
83 base::Bind(&SatisfyCallback, &blank_change), 81 base::Bind(&SatisfyCallback, &blank_change),
84 base::Bind(&RequireCallback, &required_id, &required_seq))); 82 base::Bind(&RequireCallback, &required_id, &required_seq)));
85 layer2->SetSurfaceId(SurfaceId(kArbitraryClientId, 1, 0), 1.f, 83 layer2->SetSurfaceId(SurfaceId(kArbitraryClientId, 1, 0), 1.f,
86 gfx::Size(1, 1)); 84 gfx::Size(1, 1));
87 layer_tree_host2->set_surface_client_id(2); 85 layer_tree_host2->set_surface_client_id(2);
88 layer_tree_host2->SetRootLayer(layer2); 86 layer_tree_host2->SetRootLayer(layer2);
(...skipping 11 matching lines...) Expand all
100 // satisfied. 98 // satisfied.
101 EXPECT_TRUE(blank_change == expected2); 99 EXPECT_TRUE(blank_change == expected2);
102 100
103 // Set of sequences that need to be satisfied should include sequences from 101 // Set of sequences that need to be satisfied should include sequences from
104 // both trees. 102 // both trees.
105 EXPECT_TRUE(required_id == SurfaceId(kArbitraryClientId, 1, 0)); 103 EXPECT_TRUE(required_id == SurfaceId(kArbitraryClientId, 1, 0));
106 EXPECT_EQ(2u, required_seq.size()); 104 EXPECT_EQ(2u, required_seq.size());
107 EXPECT_TRUE(required_seq.count(expected1)); 105 EXPECT_TRUE(required_seq.count(expected1));
108 EXPECT_TRUE(required_seq.count(expected2)); 106 EXPECT_TRUE(required_seq.count(expected2));
109 107
110 layer_tree_->SetRootLayer(nullptr); 108 layer_tree_host_->SetRootLayer(nullptr);
111 layer_tree_host_.reset(); 109 layer_tree_host_.reset();
112 110
113 // Layer was removed so sequence from first LayerTreeHost should be 111 // Layer was removed so sequence from first LayerTreeHost should be
114 // satisfied. 112 // satisfied.
115 EXPECT_TRUE(blank_change == expected1); 113 EXPECT_TRUE(blank_change == expected1);
116 114
117 // No more SurfaceSequences should have been generated that need to have be 115 // No more SurfaceSequences should have been generated that need to have be
118 // satisfied. 116 // satisfied.
119 EXPECT_EQ(2u, required_seq.size()); 117 EXPECT_EQ(2u, required_seq.size());
120 } 118 }
121 119
122 // Check that SurfaceSequence is sent through swap promise. 120 // Check that SurfaceSequence is sent through swap promise.
123 class SurfaceLayerSwapPromise : public LayerTreeTest { 121 class SurfaceLayerSwapPromise : public LayerTreeTest {
124 public: 122 public:
125 SurfaceLayerSwapPromise() 123 SurfaceLayerSwapPromise()
126 : commit_count_(0), sequence_was_satisfied_(false) {} 124 : commit_count_(0), sequence_was_satisfied_(false) {}
127 125
128 void BeginTest() override { 126 void BeginTest() override {
129 layer_tree_host()->set_surface_client_id(1); 127 layer_tree_host()->set_surface_client_id(1);
130 layer_ = SurfaceLayer::Create( 128 layer_ = SurfaceLayer::Create(
131 base::Bind(&SatisfyCallback, &satisfied_sequence_), 129 base::Bind(&SatisfyCallback, &satisfied_sequence_),
132 base::Bind(&RequireCallback, &required_id_, &required_set_)); 130 base::Bind(&RequireCallback, &required_id_, &required_set_));
133 layer_->SetSurfaceId(SurfaceId(kArbitraryClientId, 1, 0), 1.f, 131 layer_->SetSurfaceId(SurfaceId(kArbitraryClientId, 1, 0), 1.f,
134 gfx::Size(1, 1)); 132 gfx::Size(1, 1));
135 133
136 // Layer hasn't been added to tree so no SurfaceSequence generated yet. 134 // Layer hasn't been added to tree so no SurfaceSequence generated yet.
137 EXPECT_EQ(0u, required_set_.size()); 135 EXPECT_EQ(0u, required_set_.size());
138 136
139 layer_tree()->SetRootLayer(layer_); 137 layer_tree_host()->SetRootLayer(layer_);
140 138
141 // Should have SurfaceSequence from first tree. 139 // Should have SurfaceSequence from first tree.
142 SurfaceSequence expected(1u, 1u); 140 SurfaceSequence expected(1u, 1u);
143 EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryClientId, 1, 0)); 141 EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryClientId, 1, 0));
144 EXPECT_EQ(1u, required_set_.size()); 142 EXPECT_EQ(1u, required_set_.size());
145 EXPECT_TRUE(required_set_.count(expected)); 143 EXPECT_TRUE(required_set_.count(expected));
146 144
147 gfx::Size bounds(100, 100); 145 gfx::Size bounds(100, 100);
148 layer_tree()->SetViewportSize(bounds); 146 layer_tree_host()->SetViewportSize(bounds);
149 147
150 blank_layer_ = SolidColorLayer::Create(); 148 blank_layer_ = SolidColorLayer::Create();
151 blank_layer_->SetIsDrawable(true); 149 blank_layer_->SetIsDrawable(true);
152 blank_layer_->SetBounds(gfx::Size(10, 10)); 150 blank_layer_->SetBounds(gfx::Size(10, 10));
153 151
154 PostSetNeedsCommitToMainThread(); 152 PostSetNeedsCommitToMainThread();
155 } 153 }
156 154
157 virtual void ChangeTree() = 0; 155 virtual void ChangeTree() = 0;
158 156
(...skipping 15 matching lines...) Expand all
174 }; 172 };
175 173
176 // Check that SurfaceSequence is sent through swap promise. 174 // Check that SurfaceSequence is sent through swap promise.
177 class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise { 175 class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise {
178 public: 176 public:
179 void ChangeTree() override { 177 void ChangeTree() override {
180 ++commit_count_; 178 ++commit_count_;
181 switch (commit_count_) { 179 switch (commit_count_) {
182 case 1: 180 case 1:
183 // Remove SurfaceLayer from tree to cause SwapPromise to be created. 181 // Remove SurfaceLayer from tree to cause SwapPromise to be created.
184 layer_tree()->SetRootLayer(blank_layer_); 182 layer_tree_host()->SetRootLayer(blank_layer_);
185 break; 183 break;
186 case 2: 184 case 2:
187 break; 185 break;
188 default: 186 default:
189 NOTREACHED(); 187 NOTREACHED();
190 break; 188 break;
191 } 189 }
192 } 190 }
193 191
194 void DisplayReceivedCompositorFrameOnThread( 192 void DisplayReceivedCompositorFrameOnThread(
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 LayerTreeHostImpl::FrameData* frame, 225 LayerTreeHostImpl::FrameData* frame,
228 DrawResult draw_result) override { 226 DrawResult draw_result) override {
229 return DRAW_ABORTED_MISSING_HIGH_RES_CONTENT; 227 return DRAW_ABORTED_MISSING_HIGH_RES_CONTENT;
230 } 228 }
231 229
232 void ChangeTree() override { 230 void ChangeTree() override {
233 ++commit_count_; 231 ++commit_count_;
234 switch (commit_count_) { 232 switch (commit_count_) {
235 case 1: 233 case 1:
236 // Remove SurfaceLayer from tree to cause SwapPromise to be created. 234 // Remove SurfaceLayer from tree to cause SwapPromise to be created.
237 layer_tree()->SetRootLayer(blank_layer_); 235 layer_tree_host()->SetRootLayer(blank_layer_);
238 break; 236 break;
239 case 2: 237 case 2:
240 layer_tree_host()->SetNeedsCommit(); 238 layer_tree_host()->SetNeedsCommit();
241 break; 239 break;
242 default: 240 default:
243 EndTest(); 241 EndTest();
244 break; 242 break;
245 } 243 }
246 } 244 }
247 245
248 void AfterTest() override { 246 void AfterTest() override {
249 EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryClientId, 1, 0)); 247 EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryClientId, 1, 0));
250 EXPECT_EQ(1u, required_set_.size()); 248 EXPECT_EQ(1u, required_set_.size());
251 // Sequence should have been satisfied with the callback. 249 // Sequence should have been satisfied with the callback.
252 EXPECT_TRUE(satisfied_sequence_ == SurfaceSequence(1u, 1u)); 250 EXPECT_TRUE(satisfied_sequence_ == SurfaceSequence(1u, 1u));
253 } 251 }
254 }; 252 };
255 253
256 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithoutDraw); 254 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithoutDraw);
257 255
258 } // namespace 256 } // namespace
259 } // namespace cc 257 } // namespace cc
OLDNEW
« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | cc/layers/texture_layer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698