Add signin metrics access points used on iOS.

Add signin metrics access points used on iOS.

BUG=612908
Committed: https://crrev.com/808178fd13baf02dcf9b3d786cb1f61fd16989e6
Cr-Commit-Position: refs/heads/master@{#412784}

[bzanotti, 2016-08-17 11:58:28]

bzanotti@chromium.org changed reviewers:
+ jwd@chromium.org, rogerta@chromium.org

[bzanotti, 2016-08-17 11:58:29]

Please take a look.

Note that those actions will only be used in Chrome iOS (downstream) for now.

[jwd, 2016-08-17 16:25:46]

metrics lgtm

[Roger Tawa OOO till Jul 10th, 2016-08-17 17:20:22]

lgtm, one nit below

https://codereview.chromium.org/2253043002/diff/20001/components/signin/core/...
File components/signin/core/browser/signin_metrics.h (right):

https://codereview.chromium.org/2253043002/diff/20001/components/signin/core/...
components/signin/core/browser/signin_metrics.h:142:
ACCESS_POINT_RESIGN_IN_INFOBAR,
The separation with _ seems little off to me.  I'd suggested: xxx_RESIGNIN_xxx
or maybe xxx_RE_SIGNIN_xxx, mostly because" resign" is a real word with a
different meaning.

[bzanotti, 2016-08-18 08:45:24]

https://codereview.chromium.org/2253043002/diff/20001/components/signin/core/...
File components/signin/core/browser/signin_metrics.h (right):

https://codereview.chromium.org/2253043002/diff/20001/components/signin/core/...
components/signin/core/browser/signin_metrics.h:142:
ACCESS_POINT_RESIGN_IN_INFOBAR,
On 2016/08/17 17:20:22, Roger Tawa wrote:
> The separation with _ seems little off to me.  I'd suggested: xxx_RESIGNIN_xxx
> or maybe xxx_RE_SIGNIN_xxx, mostly because" resign" is a real word with a
> different meaning.

I was following the naming we've been using downstream, but this is a very good
point. Updated!

[bzanotti, 2016-08-18 08:45:28]

The CQ bit was checked by bzanotti@chromium.org

[bzanotti, 2016-08-18 08:45:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2253043002/#ps40001
(title: "Better naming")

[commit-bot: I haz the power, 2016-08-18 08:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 08:47:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:47:57]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bzanotti, 2016-08-18 08:53:14]

The CQ bit was checked by bzanotti@chromium.org

[bzanotti, 2016-08-18 08:53:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2253043002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-18 08:53:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 08:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:54:22]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[bzanotti, 2016-08-18 08:59:16]

The CQ bit was checked by bzanotti@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:59:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 09:11:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 09:11:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bzanotti, 2016-08-18 09:17:41]

The CQ bit was checked by bzanotti@chromium.org

[bzanotti, 2016-08-18 09:17:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2253043002/#ps80001
(title: "Add new access points to inline_login_handler.cc")

[commit-bot: I haz the power, 2016-08-18 09:18:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 10:06:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-18 10:08:22]

Description was changed from

==========
Add signin metrics access points used on iOS.

BUG=612908
==========

to

==========
Add signin metrics access points used on iOS.

BUG=612908

Committed: https://crrev.com/808178fd13baf02dcf9b3d786cb1f61fd16989e6
Cr-Commit-Position: refs/heads/master@{#412784}
==========

[commit-bot: I haz the power, 2016-08-18 10:08:23]

Patchset 5 (id:??) landed as
https://crrev.com/808178fd13baf02dcf9b3d786cb1f61fd16989e6
Cr-Commit-Position: refs/heads/master@{#412784}