Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 2253043002: Add signin metrics access points used on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add new access points to inline_login_handler.cc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/signin/core/browser/signin_metrics.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h" 5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 base::UserMetricsAction("Signin_Signin_FromPasswordBubble")); 174 base::UserMetricsAction("Signin_Signin_FromPasswordBubble"));
175 break; 175 break;
176 case signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN: 176 case signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN:
177 content::RecordAction( 177 content::RecordAction(
178 base::UserMetricsAction("Signin_Signin_FromAutofillDropdown")); 178 base::UserMetricsAction("Signin_Signin_FromAutofillDropdown"));
179 break; 179 break;
180 case signin_metrics::AccessPoint::ACCESS_POINT_NTP_CONTENT_SUGGESTIONS: 180 case signin_metrics::AccessPoint::ACCESS_POINT_NTP_CONTENT_SUGGESTIONS:
181 content::RecordAction( 181 content::RecordAction(
182 base::UserMetricsAction("Signin_Signin_FromNTPContentSuggestions")); 182 base::UserMetricsAction("Signin_Signin_FromNTPContentSuggestions"));
183 break; 183 break;
184 case signin_metrics::AccessPoint::ACCESS_POINT_RESIGNIN_INFOBAR:
185 content::RecordAction(
186 base::UserMetricsAction("Signin_Signin_FromReSigninInfobar"));
187 break;
188 case signin_metrics::AccessPoint::ACCESS_POINT_TAB_SWITCHER:
189 content::RecordAction(
190 base::UserMetricsAction("Signin_Signin_FromTabSwitcher"));
191 break;
184 case signin_metrics::AccessPoint::ACCESS_POINT_MAX: 192 case signin_metrics::AccessPoint::ACCESS_POINT_MAX:
185 NOTREACHED(); 193 NOTREACHED();
186 break; 194 break;
187 } 195 }
188 } 196 }
189 197
190 void InlineLoginHandler::ContinueHandleInitializeMessage() { 198 void InlineLoginHandler::ContinueHandleInitializeMessage() {
191 base::DictionaryValue params; 199 base::DictionaryValue params;
192 200
193 const std::string& app_locale = g_browser_process->GetApplicationLocale(); 201 const std::string& app_locale = g_browser_process->GetApplicationLocale();
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 303
296 void InlineLoginHandler::HandleDialogClose(const base::ListValue* args) { 304 void InlineLoginHandler::HandleDialogClose(const base::ListValue* args) {
297 Browser* browser = GetDesktopBrowser(web_ui()); 305 Browser* browser = GetDesktopBrowser(web_ui());
298 // If the dialog was opened in the User Manager browser will be null here. 306 // If the dialog was opened in the User Manager browser will be null here.
299 if (browser) 307 if (browser)
300 browser->CloseModalSigninWindow(); 308 browser->CloseModalSigninWindow();
301 309
302 // Does nothing if user manager is not showing. 310 // Does nothing if user manager is not showing.
303 UserManager::HideReauthDialog(); 311 UserManager::HideReauthDialog();
304 } 312 }
OLDNEW
« no previous file with comments | « no previous file | components/signin/core/browser/signin_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698