Source/web/WebLocalFrameImpl.cpp - Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix setSelectedRange arguments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index f51d641f4d6d534bcc7e607b8899dfa37d5d33d9..b5a37f89bab0804c975c0f606e4fb09c5b15e1b1 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -1238,7 +1238,7 @@ void WebLocalFrameImpl::selectRange(const WebPoint& base, const WebPoint& extent

void WebLocalFrameImpl::selectRange(const WebRange& webRange)

{

if (RefPtrWillBeRawPtr<Range> range = static_cast<PassRefPtrWillBeRawPtr<Range> >(webRange))

- frame()->selection().setSelectedRange(range.get(), WebCore::VP_DEFAULT_AFFINITY, false);

+ frame()->selection().setSelectedRange(range.get(), WebCore::VP_DEFAULT_AFFINITY, false, NotUserTriggered);

}

void WebLocalFrameImpl::moveRangeSelection(const WebPoint& base, const WebPoint& extent)

« Source/core/editing/FrameSelection.h ('K') | « Source/core/page/DOMSelection.cpp ('k') | no next file » | no next file with comments »