Chromium Code Reviews| Index: Source/core/editing/FrameSelection.h |
| diff --git a/Source/core/editing/FrameSelection.h b/Source/core/editing/FrameSelection.h |
| index 9b1aeb59acc79d216bc2c6401ed88d6d90f8df57..c59a5d0fe133cbed33bbcc094ec6cebbfaa65cef 100644 |
| --- a/Source/core/editing/FrameSelection.h |
| +++ b/Source/core/editing/FrameSelection.h |
| @@ -100,7 +100,7 @@ public: |
| const VisibleSelection& selection() const { return m_selection; } |
| void setSelection(const VisibleSelection&, SetSelectionOptions = CloseTyping | ClearTypingStyle, CursorAlignOnScroll = AlignCursorOnScrollIfNeeded, TextGranularity = CharacterGranularity); |
| void setSelection(const VisibleSelection& selection, TextGranularity granularity) { setSelection(selection, CloseTyping | ClearTypingStyle, AlignCursorOnScrollIfNeeded, granularity); } |
| - bool setSelectedRange(Range*, EAffinity, SetSelectionOptions = CloseTyping | ClearTypingStyle); |
| + bool setSelectedRange(Range*, EAffinity, bool isDirectional = false, SetSelectionOptions = CloseTyping | ClearTypingStyle); |
|
tkent
2014/06/09 07:26:22
nit: We should not introduce new bool arguments.
yoichio
2014/06/09 07:38:31
What do you mean?
tkent
2014/06/09 07:44:17
Please refer to the 10th bullet of http://dev.chro
yoichio
2014/06/09 07:46:21
I see. Will fix later:) Thanks.
|
| void selectAll(); |
| void clear(); |
| void prepareForDestruction(); |
| @@ -149,6 +149,7 @@ public: |
| bool isRange() const { return m_selection.isRange(); } |
| bool isCaretOrRange() const { return m_selection.isCaretOrRange(); } |
| bool isInPasswordField() const; |
| + bool isDirectional() const { return m_selection.isDirectional(); } |
| // If this FrameSelection has a logical range which is still valid, this function return its clone. Otherwise, |
| // the return value from underlying VisibleSelection's firstRange() is returned. |