LayoutTests/fast/css/counters/counter-before-content-not-incremented.html - Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css/counters/counter-before-content-not-incremented.html

Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix setSelectedRange arguments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/selection/selection-invalid-offset-expected.txt ('k') | Source/core/editing/EditorCommand.cpp » ('j') | Source/core/editing/FrameSelection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css/counters/counter-before-content-not-incremented.html

diff --git a/LayoutTests/fast/css/counters/counter-before-content-not-incremented.html b/LayoutTests/fast/css/counters/counter-before-content-not-incremented.html

index b2e5be7c54b493ac243a523fba8d861908f5c68f..a100c3403c13f8ed086adaf7fd1c67effa8fbd62 100644

--- a/LayoutTests/fast/css/counters/counter-before-content-not-incremented.html

+++ b/LayoutTests/fast/css/counters/counter-before-content-not-incremented.html

@@ -26,7 +26,7 @@

// We need to use the selection or we cannot reproduce this bug!

var selection = window.getSelection();

var container = document.getElementById("container");

- selection.collapse(container, 0);

+ selection.collapse(container.firstChild, 0);

if (selection.rangeCount > 0) {

var newElement = document.createElement('div');

newElement.id = 'div' + i;