LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js - Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix setSelectedRange arguments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/selection/no-range-canonicalization-expected.txt ('k') | LayoutTests/editing/selection/selection-invalid-offset.html » ('j') | Source/core/editing/FrameSelection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

diff --git a/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js b/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

index 596c07013595f369a0049543f751ec8c1f91d3e1..d44f417b258c06a0f2d196af2b56e0e7a6265ced 100644

--- a/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

+++ b/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

@@ -9,8 +9,7 @@ shouldBeNull("sel.anchorNode");

sel.setBaseAndExtent(null, 0, docType, 0);

shouldBeNull("sel.anchorNode");

-sel.collapse(docType);

-shouldBeNull("sel.anchorNode");

+shouldThrow("sel.collapse(docType)", '"InvalidNodeTypeError: Failed to execute \'collapse\' on \'Selection\': The node provided is of type \'c\'."');

sel.selectAllChildren(docType);

shouldBeNull("sel.anchorNode");