Source/core/editing/FrameSelection.cpp - Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/selection/selection-invalid-offset.html ('K') | « LayoutTests/platform/win/editing/pasteboard/smart-paste-003-expected.txt ('k') | Source/core/page/DOMSelection.cpp » ('j') | Source/core/page/DOMSelection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 4e72e8c317979864b9730bbc34459d17d35e6c9f..337a1b7dc08977c1d8caa9473b8004240690c1c1 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -1414,7 +1414,7 @@ bool FrameSelection::setSelectedRange(Range* range, EAffinity affinity, SetSelec

m_logicalRange = nullptr;

stopObservingVisibleSelectionChangeIfNecessary();

- VisibleSelection newSelection(range, affinity);

+ VisibleSelection newSelection(range, affinity, range->collapsed() ? m_selection.isDirectional() : true);

setSelection(newSelection, options);

m_logicalRange = range->cloneRange();