LayoutTests/editing/selection/selection-invalid-offset.html - Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/selection/selection-invalid-offset.html

Issue 225303002: Let Selection.collapse remember a raw Position instead of a canonicalized one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js ('k') | LayoutTests/editing/selection/selection-invalid-offset-expected.txt » ('j') | Source/core/page/DOMSelection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/selection/selection-invalid-offset.html

diff --git a/LayoutTests/editing/selection/selection-invalid-offset.html b/LayoutTests/editing/selection/selection-invalid-offset.html

index 8393b16e3187df2c741c47b7e2785a8e0ed823ab..5e5a3f0b64ced2cc898503979d1150e1ffd4bc87 100644

--- a/LayoutTests/editing/selection/selection-invalid-offset.html

+++ b/LayoutTests/editing/selection/selection-invalid-offset.html

@@ -1,5 +1,5 @@

<body>

-You should see six OKs below (and not hang): <br>

+You should see 7 OKs below (and not hang): <br>

if (window.testRunner)

testRunner.dumpAsText();

@@ -30,8 +30,10 @@ selection.getRangeAt(10000);

} catch (e) {document.write(((e.code==DOMException.INDEX_SIZE_ERR) ? "OK" : "FAIL")+"<br>"); }

// these should throw as well but don't at the moment. Just checking they don't crash.

Yuta Kitamura 2014/06/05 09:09:28 The location of this comment is inappropriate.

yoichio 2014/06/06 07:54:49 Done.

+try {

selection.collapse(body, 10000);

+} catch (e) {document.write(((e.code==DOMException.INDEX_SIZE_ERR) ? "OK" : "FAIL")+"<br>"); }

Yuta Kitamura 2014/06/05 09:09:28 optional: I know it's not your fault, but the form

yoichio 2014/06/06 07:54:49 Done.

selection.setBaseAndExtent(body, 1000, body, 0);

selection.setBaseAndExtent(body, 0, body, 10000);

-selection.collapse(body, 10000);

</script>