Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2252963007:
PDF rotation should maintain current page. (Closed)
DescriptionPDF rotation should maintain current page.
BUG=116297
Committed: https://crrev.com/1c88d60dafe131271c5cd43b938956ecbc700514
Cr-Commit-Position: refs/heads/master@{#413659}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rebase #Patch Set 3 : Add TODO #
Messages
Total messages: 26 (14 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thestig@chromium.org changed reviewers: + raymes@chromium.org
This is the easy but not most accurate fix because it doesn't perfectly adjust the scroll position. But this gets us mostly there, so let's get the bug fixed-ish sooner than later.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2252963007/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/2252963007/diff/1/pdf/pdfium/pdfium_engine.cc... pdf/pdfium/pdfium_engine.cc:3380: // the scroll position has not. Readjust. Possibly add a note that we should restore the position of that page?
https://codereview.chromium.org/2252963007/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/2252963007/diff/1/pdf/pdfium/pdfium_engine.cc... pdf/pdfium/pdfium_engine.cc:3380: // the scroll position has not. Readjust. On 2016/08/22 01:09:30, raymes wrote: > Possibly add a note that we should restore the position of that page? Done.
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org Link to the patchset: https://codereview.chromium.org/2252963007/#ps40001 (title: "Add TODO")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== PDF rotation should maintain current page. BUG=116297 ========== to ========== PDF rotation should maintain current page. BUG=116297 Committed: https://crrev.com/1c88d60dafe131271c5cd43b938956ecbc700514 Cr-Commit-Position: refs/heads/master@{#413659} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1c88d60dafe131271c5cd43b938956ecbc700514 Cr-Commit-Position: refs/heads/master@{#413659} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
