Make TrustStore into an interface, move impl to TrustStoreInMemory.

Make TrustStore into an interface, move impl to TrustStoreInMemory.

BUG=635203
Committed: https://crrev.com/c72913b94e4d44fb5b510b6f0e9e316c84004a9a
Cr-Commit-Position: refs/heads/master@{#413540}

[mattm, 2016-08-17 00:15:37]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 00:16:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2016-08-17 00:17:37]

mattm@chromium.org changed reviewers:
+ eroman@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:30:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:30:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mattm, 2016-08-17 01:09:29]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 01:09:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 01:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 01:26:47]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[mattm, 2016-08-17 01:39:04]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 01:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2016-08-17 03:12:54]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 03:13:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 04:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 04:07:20]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-08-18 21:13:38]

Also there are some instances of "const TrustStore&" in path_builder.cc what I
think would be better written as "const TrustStore*" now that it is an
interface. Not sure what the style guide says about this.

https://codereview.chromium.org/2252933002/diff/80001/net/cert/internal/trust...
File net/cert/internal/trust_store.h (right):

https://codereview.chromium.org/2252933002/diff/80001/net/cert/internal/trust...
net/cert/internal/trust_store.h:121: virtual void
FindTrustAnchorsByNormalizedName(
Do you think we will need to make this async in the future for system trust
store integrations?

https://codereview.chromium.org/2252933002/diff/80001/net/cert/internal/trust...
File net/cert/internal/trust_store_static.h (right):

https://codereview.chromium.org/2252933002/diff/80001/net/cert/internal/trust...
net/cert/internal/trust_store_static.h:23: class NET_EXPORT TrustStoreStatic :
public TrustStore {
I am not sure about the name "Static".

To me that implies it is not "dynamic", however this implementation supports
dynamically growing and shrinking.

How about qualifiers like:
 * InMemory
 * Simple

[mattm, 2016-08-18 22:15:21]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 22:16:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2016-08-18 22:18:22]

On 2016/08/18 21:13:38, eroman wrote:
> Also there are some instances of "const TrustStore&" in path_builder.cc what I
> think would be better written as "const TrustStore*" now that it is an
> interface. Not sure what the style guide says about this.

I don't think there's anything inherently wrong with it.. The style guide
doesn't seem to mention it that I could see.

So I think the style guide recommendations about whether to use a pointer or
reference depending on if the method holds a pointer to the object past method
return would still apply.

https://codereview.chromium.org/2252933002/diff/80001/net/cert/internal/trust...
File net/cert/internal/trust_store.h (right):

https://codereview.chromium.org/2252933002/diff/80001/net/cert/internal/trust...
net/cert/internal/trust_store.h:121: virtual void
FindTrustAnchorsByNormalizedName(
On 2016/08/18 21:13:38, eroman wrote:
> Do you think we will need to make this async in the future for system trust
> store integrations?

yes, I'm saving that for a followup. Just wanted to get the renaming of
TrustStore in all those files out of the way.

https://codereview.chromium.org/2252933002/diff/80001/net/cert/internal/trust...
File net/cert/internal/trust_store_static.h (right):

https://codereview.chromium.org/2252933002/diff/80001/net/cert/internal/trust...
net/cert/internal/trust_store_static.h:23: class NET_EXPORT TrustStoreStatic :
public TrustStore {
On 2016/08/18 21:13:38, eroman wrote:
> I am not sure about the name "Static".
> 
> To me that implies it is not "dynamic", however this implementation supports
> dynamically growing and shrinking.
> 
> How about qualifiers like:
>  * InMemory
>  * Simple

Done.

[mattm, 2016-08-18 22:19:35]

Description was changed from

==========
Make TrustStore into an interface, move impl to TrustStoreStatic.

BUG=635203
==========

to

==========
Make TrustStore into an interface, move impl to TrustStoreInMemory.

BUG=635203
==========

[eroman, 2016-08-18 23:19:06]

lgtm

[mattm, 2016-08-18 23:23:37]

mattm@chromium.org changed reviewers:
+ sheretov@chromium.org

[mattm, 2016-08-18 23:23:38]

+sheretov for cast owners

[commit-bot: I haz the power, 2016-08-19 00:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 00:49:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mattm, 2016-08-19 02:26:13]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 02:26:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 02:42:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 02:42:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mattm, 2016-08-19 02:51:40]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 02:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 04:49:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 04:49:58]

Dry run: This issue passed the CQ dry run.

[sheretov, 2016-08-22 16:37:27]

lgtm

[mattm, 2016-08-22 19:55:43]

The CQ bit was checked by mattm@chromium.org

[mattm, 2016-08-22 19:55:44]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2252933002/#ps140001
(title: "update cast_cert_validator_unittest.cc")

[commit-bot: I haz the power, 2016-08-22 19:56:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:36:59]

Description was changed from

==========
Make TrustStore into an interface, move impl to TrustStoreInMemory.

BUG=635203
==========

to

==========
Make TrustStore into an interface, move impl to TrustStoreInMemory.

BUG=635203
==========

[commit-bot: I haz the power, 2016-08-22 21:37:00]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-08-22 21:39:10]

Description was changed from

==========
Make TrustStore into an interface, move impl to TrustStoreInMemory.

BUG=635203
==========

to

==========
Make TrustStore into an interface, move impl to TrustStoreInMemory.

BUG=635203

Committed: https://crrev.com/c72913b94e4d44fb5b510b6f0e9e316c84004a9a
Cr-Commit-Position: refs/heads/master@{#413540}
==========

[commit-bot: I haz the power, 2016-08-22 21:39:12]

Patchset 8 (id:??) landed as
https://crrev.com/c72913b94e4d44fb5b510b6f0e9e316c84004a9a
Cr-Commit-Position: refs/heads/master@{#413540}