Make TrustStore into an interface, move impl to TrustStoreInMemory.

net/cert/internal/trust_store.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_INTERNAL_TRUST_STORE_H_
 #define NET_CERT_INTERNAL_TRUST_STORE_H_
 
-#include <unordered_map>
 #include <vector>
 
 #include "base/memory/ref_counted.h"
-#include "base/strings/string_piece.h"
 #include "net/base/net_export.h"
 #include "net/cert/internal/parsed_certificate.h"
 
 namespace net {
 
 namespace der {
 class Input;
 }
 
 // A TrustAnchor represents a trust anchor used during RFC 5280 path validation.
@@ skipping 83 matching lines @@
   friend class base::RefCountedThreadSafe<TrustAnchor>;
   TrustAnchor(scoped_refptr<ParsedCertificate>, bool enforces_constraints);
   ~TrustAnchor();
 
   scoped_refptr<ParsedCertificate> cert_;
   bool enforces_constraints_ = false;
 };
 
 using TrustAnchors = std::vector<scoped_refptr<TrustAnchor>>;
 
-// A very simple implementation of a TrustStore, which contains a set of
-// trust anchors.
-//
-// TODO(mattm): convert this into an interface, provide implementations that
-// interface with OS trust store.
+// Interface for finding trust anchors.
 class NET_EXPORT TrustStore {
  public:
   TrustStore();
-  ~TrustStore();
-
-  // Empties the trust store, resetting it to original state.
-  void Clear();
-
-  void AddTrustAnchor(scoped_refptr<TrustAnchor> anchor);
+  virtual ~TrustStore();
 
   // Returns the trust anchors that match |name| in |*matches|, if any.
-  void FindTrustAnchorsByNormalizedName(const der::Input& normalized_name,
-                                        TrustAnchors* matches) const;
+  virtual void FindTrustAnchorsByNormalizedName(

[eroman, 2016/08/18 21:13:38]

Do you think we will need to make this async in the future for system trust
store integrations?

[mattm, 2016/08/18 22:18:22]

yes, I'm saving that for a followup. Just wanted to get the renaming of
TrustStore in all those files out of the way.

+      const der::Input& normalized_name,
+      TrustAnchors* matches) const = 0;
 
  private:
-  // Multimap from normalized subject -> TrustAnchor.
-  std::unordered_multimap<base::StringPiece,
-                          scoped_refptr<TrustAnchor>,
-                          base::StringPieceHash>
-      anchors_;
-
   DISALLOW_COPY_AND_ASSIGN(TrustStore);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_INTERNAL_TRUST_STORE_H_