Issue 2252903002: Reset previous WKBackForwardListeItem when navigating to WebUI pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2252903002: Reset previous WKBackForwardListeItem when navigating to WebUI pages. (Closed)

Created:
4 years, 4 months ago by kkhorimoto

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reset previous WKBackForwardListeItem when navigating to WebUI pages. Navigation to WebUI pages overwrites the current WKBackForwardListeItem such that it will load the WebUI page's URL and HTML when loaded via |-goToBackForwardListItem:|. This CL resets the previous NavigationItem's associated WKBackForwardListItem to ensure that it is loaded via an NSURLRequest rather than the WKBackForwardListeItem. BUG=628920 Review-Url: https://codereview.chromium.org/2233063002 Cr-Commit-Position: refs/heads/master@{#411399} (cherry picked from commit 4838fe571d972fdbe6b76162c17ec1feb4035695)

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	ios/web/web_state/ui/crw_web_controller.mm	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

kkhorimoto

4 years, 4 months ago (2016-08-16 22:41:23 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
6aa2ab3c6796cd41595ea7ee5069d3ddc8827d94.

Expand Messages | Collapse Messages