Reset previous WKBackForwardListeItem when navigating to WebUI pages.

Reset previous WKBackForwardListeItem when navigating to WebUI pages.

Navigation to WebUI pages overwrites the current WKBackForwardListeItem
such that it will load the WebUI page's URL and HTML when loaded via
|-goToBackForwardListItem:|.  This CL resets the previous
NavigationItem's associated WKBackForwardListItem to ensure that it is
loaded via an NSURLRequest rather than the WKBackForwardListeItem.

BUG=628920
Committed: https://crrev.com/4838fe571d972fdbe6b76162c17ec1feb4035695
Cr-Commit-Position: refs/heads/master@{#411399}

[kkhorimoto, 2016-08-10 18:28:14]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-08-10 18:46:42]

eugenebut@chromium.org changed reviewers:
+ jyquinn@chromium.org

[Eugene But (OOO till 7-30), 2016-08-10 18:46:43]

lgtm, would be good if Jackie also take a look.

[kkhorimoto, 2016-08-11 18:25:29]

PTAL, Jackie! I'd like to get this landed and cherry-picked for M53, as it
prevents a url spoofing attack.

[Jackie Quinn, 2016-08-11 18:42:32]

On 2016/08/11 18:25:29, kkhorimoto_ wrote:
> PTAL, Jackie! I'd like to get this landed and cherry-picked for M53, as it
> prevents a url spoofing attack.

lgtm with comment clarification

[Jackie Quinn, 2016-08-11 18:42:38]

https://codereview.chromium.org/2233063002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2233063002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2325: // WKBackForwardListeItem,
causing a mismatch between the visible content and
extra e in WKBackForwardListItem.

Also could you mention explicitly is that the mismatch is the WebUI HTML being
loaded while the previous URL is shown?

[kkhorimoto, 2016-08-11 18:47:10]

https://codereview.chromium.org/2233063002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2233063002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:2325: // WKBackForwardListeItem,
causing a mismatch between the visible content and
On 2016/08/11 18:42:38, Jackie Quinn wrote:
> extra e in WKBackForwardListItem.
> 
> Also could you mention explicitly is that the mismatch is the WebUI HTML being
> loaded while the previous URL is shown?

Done.

[kkhorimoto, 2016-08-11 18:47:14]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-08-11 18:47:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org, jyquinn@chromium.org
Link to the patchset: https://codereview.chromium.org/2233063002/#ps20001
(title: "Comment clarification")

[commit-bot: I haz the power, 2016-08-11 18:47:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:25:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 19:28:30]

Description was changed from

==========
Reset previous WKBackForwardListeItem when navigating to WebUI pages.

Navigation to WebUI pages overwrites the current WKBackForwardListeItem
such that it will load the WebUI page's URL and HTML when loaded via
|-goToBackForwardListItem:|.  This CL resets the previous
NavigationItem's associated WKBackForwardListItem to ensure that it is
loaded via an NSURLRequest rather than the WKBackForwardListeItem.

BUG=628920
==========

to

==========
Reset previous WKBackForwardListeItem when navigating to WebUI pages.

Navigation to WebUI pages overwrites the current WKBackForwardListeItem
such that it will load the WebUI page's URL and HTML when loaded via
|-goToBackForwardListItem:|.  This CL resets the previous
NavigationItem's associated WKBackForwardListItem to ensure that it is
loaded via an NSURLRequest rather than the WKBackForwardListeItem.

BUG=628920

Committed: https://crrev.com/4838fe571d972fdbe6b76162c17ec1feb4035695
Cr-Commit-Position: refs/heads/master@{#411399}
==========

[commit-bot: I haz the power, 2016-08-11 19:28:31]

Patchset 2 (id:??) landed as
https://crrev.com/4838fe571d972fdbe6b76162c17ec1feb4035695
Cr-Commit-Position: refs/heads/master@{#411399}