src/compiler/instruction-selector.cc - Issue 2252863003: [turbofan] Add Float32(Max|Min) machine operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction-selector.cc

Issue 2252863003: [turbofan] Add Float32(Max|Min) machine operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Extract the code of the (min|max) calculation. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/instruction-selector.cc

diff --git a/src/compiler/instruction-selector.cc b/src/compiler/instruction-selector.cc

index 86b8c10ff238095b7b66c00d16c11ebb77c9c03e..ac8e64a58a5528782cd8618af6197246ae7b4bfc 100644

--- a/src/compiler/instruction-selector.cc

+++ b/src/compiler/instruction-selector.cc

@@ -1151,6 +1151,10 @@ void InstructionSelector::VisitNode(Node* node) {

return VisitFloat32LessThan(node);

case IrOpcode::kFloat32LessThanOrEqual:

return VisitFloat32LessThanOrEqual(node);

+ case IrOpcode::kFloat32Max:

+ return MarkAsFloat32(node), VisitFloat32Max(node);

+ case IrOpcode::kFloat32Min:

+ return MarkAsFloat32(node), VisitFloat32Min(node);

case IrOpcode::kFloat64Add:

return MarkAsFloat64(node), VisitFloat64Add(node);

case IrOpcode::kFloat64Sub: