Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: src/compiler/typer.cc

Issue 2252863003: [turbofan] Add Float32(Max|Min) machine operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Extract the code of the (min|max) calculation. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/raw-machine-assembler.h ('k') | src/compiler/verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index 37d9a94006ff7a7501fc9bb93bdd81da26215db2..9cb67d75f84a3d6cc58f09dcb97b1536c5c84b88 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -2084,6 +2084,9 @@ Type* Typer::Visitor::TypeFloat32LessThanOrEqual(Node* node) {
return Type::Boolean();
}
+Type* Typer::Visitor::TypeFloat32Max(Node* node) { return Type::Number(); }
Jarin 2016/08/18 07:42:42 Is this even reachable? If not, could you just say
titzer 2016/08/18 08:23:01 If we leave it Number, it should be correct, and w
ahaas 2016/08/18 12:54:40 As discussed with jarin@ offline, I put UNREACHABL
+
+Type* Typer::Visitor::TypeFloat32Min(Node* node) { return Type::Number(); }
Type* Typer::Visitor::TypeFloat64Add(Node* node) { return Type::Number(); }
« no previous file with comments | « src/compiler/raw-machine-assembler.h ('k') | src/compiler/verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698