Deal with synchronous errors in Future.wait.

Deal with synchronous errors in Future.wait.

Synchronous errors are caught and piped into the returned future. This makes handling errors in Future.wait uniform.

Fixes #23656
BUG= http://dartbug.com/23656
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/33b7b452525858c0d45e1773cd47dd39607f3aa1

[floitsch, 2016-08-17 19:54:36]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-08-18 11:15:08]

lgtm

https://codereview.chromium.org/2252823004/diff/20001/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/2252823004/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:315: // reach the line).
change parenthesized comment to:
, and we also don't increment `remaining`.

https://codereview.chromium.org/2252823004/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:326: // Just complete the error ourselves.
ourselves -> immediately.

https://codereview.chromium.org/2252823004/diff/20001/tests/lib/async/future_...
File tests/lib/async/future_test.dart (right):

https://codereview.chromium.org/2252823004/diff/20001/tests/lib/async/future_...
tests/lib/async/future_test.dart:886: Future.wait(new Iterable.generate(4, (i) {
change to 5, so there is a potential element after the throw.
It won't be reachable since the iterator breaks on the throw, but just to be
safe.

https://codereview.chromium.org/2252823004/diff/20001/tests/lib/async/future_...
tests/lib/async/future_test.dart:890: Expect.isTrue(0 <= index && index < 4);
< 3
Likely not necessary since you use `index` as index into a 3-long array.

[floitsch, 2016-08-18 11:42:55]

https://codereview.chromium.org/2252823004/diff/20001/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/2252823004/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:315: // reach the line).
On 2016/08/18 11:15:08, Lasse Reichstein Nielsen wrote:
> change parenthesized comment to:
> , and we also don't increment `remaining`.

Done.

https://codereview.chromium.org/2252823004/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:326: // Just complete the error ourselves.
On 2016/08/18 11:15:08, Lasse Reichstein Nielsen wrote:
> ourselves -> immediately.

Done.

https://codereview.chromium.org/2252823004/diff/20001/tests/lib/async/future_...
File tests/lib/async/future_test.dart (right):

https://codereview.chromium.org/2252823004/diff/20001/tests/lib/async/future_...
tests/lib/async/future_test.dart:886: Future.wait(new Iterable.generate(4, (i) {
On 2016/08/18 11:15:08, Lasse Reichstein Nielsen wrote:
> change to 5, so there is a potential element after the throw.
> It won't be reachable since the iterator breaks on the throw, but just to be
> safe.

Done.

https://codereview.chromium.org/2252823004/diff/20001/tests/lib/async/future_...
tests/lib/async/future_test.dart:890: Expect.isTrue(0 <= index && index < 4);
On 2016/08/18 11:15:08, Lasse Reichstein Nielsen wrote:
> < 3
> Likely not necessary since you use `index` as index into a 3-long array.

Removed the check.

[floitsch, 2016-08-18 12:09:25]

Description was changed from

==========
Deal with synchronous errors in Future.wait.

Synchronous errors are caught and piped into the returned future. This makes
handling errors in Future.wait uniform.

Fixes #23656
BUG= http://dartbug.com/23656
==========

to

==========
Deal with synchronous errors in Future.wait.

Synchronous errors are caught and piped into the returned future. This makes
handling errors in Future.wait uniform.

Fixes #23656
BUG= http://dartbug.com/23656
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/33b7b452525858c0d45e1773cd47dd39607f3aa1
==========

[floitsch, 2016-08-18 12:09:26]

Committed patchset #3 (id:40001) manually as
33b7b452525858c0d45e1773cd47dd39607f3aa1 (presubmit successful).