Deal with synchronous errors in Future.wait.

tests/lib/async/future_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library future_test;
 
 import 'package:async_helper/async_helper.dart';
 import "package:expect/expect.dart";
 import 'dart:async';
 
@@ skipping 858 matching lines @@
           });
 
   }, onError: (int index, s) {
     Expect.isTrue(index == 0 || index == 2, "$index");
     Expect.isFalse(uncaughts[index]);
     uncaughts[index] = true;
     asyncEnd();
   });
 }
 
+void testWaitSyncError() {
+  var cms = const Duration(milliseconds: 100);
+  var cleanups = new List.filled(3, false);
+  var uncaughts = new List.filled(3, false);
+  asyncStart();
+  asyncStart();
+  runZoned(() {
+    Future.wait(new Iterable.generate(4, (i) {

[Lasse Reichstein Nielsen, 2016/08/18 11:15:08]

change to 5, so there is a potential element after the throw.
It won't be reachable since the iterator breaks on the throw, but just to be
safe.

[floitsch, 2016/08/18 11:42:55]

Done.

+      if (i != 3) return new Future.delayed(cms * (i + 1), () => i);
+      throw "throwing synchronously in iterable";
+    }), cleanUp: (index) {
+      Expect.isTrue(0 <= index && index < 4);

[Lasse Reichstein Nielsen, 2016/08/18 11:15:08]

< 3
Likely not necessary since you use `index` as index into a 3-long array.

[floitsch, 2016/08/18 11:42:55]

Removed the check.

+      Expect.isFalse(cleanups[index]);
+      cleanups[index] = true;
+      if (cleanups.every((x) => x)) asyncEnd();
+    });
+  }, onError: (e, s) {
+    asyncEnd();
+  });
+}
+
 void testBadFuture() {
   var bad = new BadFuture();
   // Completing with bad future (then call throws) puts error in result.
   asyncStart();
   Completer completer = new Completer();
   completer.complete(bad);
   completer.future.then((_) { Expect.fail("unreachable"); },
                         onError: (e, s) {
                           Expect.isTrue(completer.isCompleted);
                           asyncEnd();
@@ skipping 179 matching lines @@
   testFutureCatchRethrowsAsync();
 
   testChainedFutureValue();
   testChainedFutureValueDelay();
   testChainedFutureError();
 
   testSyncFuture_i13368();
 
   testWaitCleanUp();
   testWaitCleanUpError();
+  testWaitSyncError();
 
   testBadFuture();
 
   testTypes();
 
   testAnyValue();
   testAnyError();
   testAnyIgnoreIncomplete();
   testAnyIgnoreError();
 
@@ skipping 51 matching lines @@
   Future whenComplete(action()) {
     return new Future.microtask(action).then((_) => this);
   }
   Stream asStream() {
     return (new StreamController()..add(_result)..close()).stream;
   }
   Future timeout(Duration duration, {onTimeout()}) {
     return this;
   }
 }