Add promise to pointerevent wpt automations

Add promise to pointerevent wpt automations

We return a promise from the APIs that send
user actions and we will fulfill them using
the callbacks in GPU benchmarking API.

Note that the callback in GPU benchmarking
is not called when the action is actually done.
Instead when the action is put in the queue to be
done. So that callback behavior needs to be fixed
later.

BUG=638239
Committed: https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db
Cr-Commit-Position: refs/heads/master@{#412611}

[Navid Zolghadr, 2016-08-16 14:40:38]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 14:40:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-08-16 15:16:35]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org

[commit-bot: I haz the power, 2016-08-16 16:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 16:26:02]

Dry run: This issue passed the CQ dry run.

[mustaq, 2016-08-17 15:17:49]

https://codereview.chromium.org/2252683002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js
(right):

https://codereview.chromium.org/2252683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:72:
reject();
I think it reject the Promise if gpuBenchmarking.tap() fails to call back within
a certain time period, right?

[Navid Zolghadr, 2016-08-17 15:24:54]

https://codereview.chromium.org/2252683002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js
(right):

https://codereview.chromium.org/2252683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:72:
reject();
On 2016/08/17 15:17:49, mustaq wrote:
> I think it reject the Promise if gpuBenchmarking.tap() fails to call back
within
> a certain time period, right?

I don't think we should make this distinction there. if that didn't call the
callback the test will timeout.

[mustaq, 2016-08-17 15:59:22]

https://codereview.chromium.org/2252683002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
(right):

https://codereview.chromium.org/2252683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js:4:
touchScrollInTarget('row1', 'down');
The top two Promises are handled differently from the touchScrollInTarget()
calls in all other injected scripts. And in this case, I find the older code
better. Wdyt?

Is there any way to avoid the setTimeout() calls by modifying the w3c tests?

[Navid Zolghadr, 2016-08-17 16:11:41]

https://codereview.chromium.org/2252683002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
(right):

https://codereview.chromium.org/2252683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js:4:
touchScrollInTarget('row1', 'down');
On 2016/08/17 15:59:22, mustaq wrote:
> The top two Promises are handled differently from the touchScrollInTarget()
> calls in all other injected scripts. And in this case, I find the older code
> better. Wdyt?
> 
> Is there any way to avoid the setTimeout() calls by modifying the w3c tests?

The old way was incorrect. It was queuing all the actions (beside the first one)
to be done after 2*scrollReturnInterval. But they should be done with that delay
after the last action. It was working before because the last 2
touchScrollUpInTarget don't and shouldn't do anything.

Adding the "then" for the first or the rest of the calls here doesn't do much as
this test particularly relies on those delays in side the test and the main
difference comes from that. I should be able to clean up this automation and
make it similar to others if we get rid of that timeout in w3c test itself. That
should be possible to modify the w3c test to get rid of the timeouts but I
haven't looked at it yet.
It seems that people don't put much time in the reviews of wp tests even though
I pinged them. I guess I need to wait for Rick to come back to do those wpt
changes faster.

[mustaq, 2016-08-17 16:35:18]

lgtm

[lanwei, 2016-08-17 17:42:37]

Description was changed from

==========
Add promise to pointerevent wpt automations

We return a promise from the APIs that send
user actions and we will fulfill them using
the callbacks in GPU benchmarking API.

Note that the callback in GPU benchmarking
is not called when the action is actually done.
Instead when the action is put in the queue to be
done. So that callback behavior needs to be fixed
later.

BUG=638239
==========

to

==========
Add promise to pointerevent wpt automations

We return a promise from the APIs that send
user actions and we will fulfill them using
the callbacks in GPU benchmarking API.

Note that the callback in GPU benchmarking
is not called when the action is actually done.
Instead when the action is put in the queue to be
done. So that callback behavior needs to be fixed
later.

BUG=638239
==========

[dtapuska, 2016-08-17 18:00:07]

On 2016/08/17 16:35:18, mustaq wrote:
> lgtm

lgtm

[Navid Zolghadr, 2016-08-17 18:00:46]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-08-17 18:01:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 19:26:32]

Description was changed from

==========
Add promise to pointerevent wpt automations

We return a promise from the APIs that send
user actions and we will fulfill them using
the callbacks in GPU benchmarking API.

Note that the callback in GPU benchmarking
is not called when the action is actually done.
Instead when the action is put in the queue to be
done. So that callback behavior needs to be fixed
later.

BUG=638239
==========

to

==========
Add promise to pointerevent wpt automations

We return a promise from the APIs that send
user actions and we will fulfill them using
the callbacks in GPU benchmarking API.

Note that the callback in GPU benchmarking
is not called when the action is actually done.
Instead when the action is put in the queue to be
done. So that callback behavior needs to be fixed
later.

BUG=638239
==========

[commit-bot: I haz the power, 2016-08-17 19:26:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 19:34:21]

Description was changed from

==========
Add promise to pointerevent wpt automations

We return a promise from the APIs that send
user actions and we will fulfill them using
the callbacks in GPU benchmarking API.

Note that the callback in GPU benchmarking
is not called when the action is actually done.
Instead when the action is put in the queue to be
done. So that callback behavior needs to be fixed
later.

BUG=638239
==========

to

==========
Add promise to pointerevent wpt automations

We return a promise from the APIs that send
user actions and we will fulfill them using
the callbacks in GPU benchmarking API.

Note that the callback in GPU benchmarking
is not called when the action is actually done.
Instead when the action is put in the queue to be
done. So that callback behavior needs to be fixed
later.

BUG=638239

Committed: https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db
Cr-Commit-Position: refs/heads/master@{#412611}
==========

[commit-bot: I haz the power, 2016-08-17 19:34:23]

Patchset 1 (id:??) landed as
https://crrev.com/698aa9d870b2cd6f52e75efd2989985f96d1d5db
Cr-Commit-Position: refs/heads/master@{#412611}