Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js

Issue 2252683002: Add promise to pointerevent wpt automations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
diff --git a/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js b/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
index b1d4bb6c280546cecba56d871b30a73108bafec1..fe32faef42df9cc04c3040bcd8933aa55b7e2aa9 100644
--- a/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
+++ b/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
@@ -1,22 +1,15 @@
importAutomationScript('/pointerevents/pointerevent_common_input.js');
-function callback_function() {
- window.setTimeout(function() {
- touchTapInTarget('btnComplete');}
- , 2 * scrollReturnInterval);
-}
-
function inject_input() {
- touchScrollUpInTarget('row1');
- window.setTimeout(function() {
- touchScrollLeftInTarget('row1');
- } , 2*scrollReturnInterval);
-
- window.setTimeout(function() {
- touchScrollUpInTarget('cell3');
- } , 2*scrollReturnInterval);
-
- window.setTimeout(function() {
- touchScrollLeftInTarget('cell3', callback_function);
- } , 2*scrollReturnInterval);
-}
+ touchScrollInTarget('row1', 'down');
mustaq 2016/08/17 15:59:22 The top two Promises are handled differently from
Navid Zolghadr 2016/08/17 16:11:41 The old way was incorrect. It was queuing all the
+ window.setTimeout(function() {
+ touchScrollInTarget('row1', 'right');
+ window.setTimeout(function() {
+ touchScrollInTarget('cell3', 'down').then(function() {
+ return touchScrollInTarget('cell3', 'right');
+ }).then(function() {
+ touchTapInTarget('btnComplete');
+ });
+ } , 2 * scrollReturnInterval);
+ } , 2 * scrollReturnInterval);
+}

Powered by Google App Engine
This is Rietveld 408576698