Add promise to pointerevent wpt automations

third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js

Index: third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
diff --git a/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js b/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
index b1d4bb6c280546cecba56d871b30a73108bafec1..fe32faef42df9cc04c3040bcd8933aa55b7e2aa9 100644
--- a/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
+++ b/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
@@ -1,22 +1,15 @@
 importAutomationScript('/pointerevents/pointerevent_common_input.js');
 
-function callback_function() {
-  window.setTimeout(function() {
-    touchTapInTarget('btnComplete');}
-    , 2 * scrollReturnInterval);
-}
-
 function inject_input() {
-  touchScrollUpInTarget('row1');
-  window.setTimeout(function() {
-    touchScrollLeftInTarget('row1');
-    } , 2*scrollReturnInterval);
-
-  window.setTimeout(function() {
-    touchScrollUpInTarget('cell3');
-    } , 2*scrollReturnInterval);
-
-  window.setTimeout(function() {
-    touchScrollLeftInTarget('cell3', callback_function);
-    } , 2*scrollReturnInterval);
-}
+  touchScrollInTarget('row1', 'down');

[mustaq, 2016/08/17 15:59:22]

The top two Promises are handled differently from the touchScrollInTarget()
calls in all other injected scripts. And in this case, I find the older code
better. Wdyt?

Is there any way to avoid the setTimeout() calls by modifying the w3c tests?

[Navid Zolghadr, 2016/08/17 16:11:41]

The old way was incorrect. It was queuing all the actions (beside the first one)
to be done after 2*scrollReturnInterval. But they should be done with that delay
after the last action. It was working before because the last 2
touchScrollUpInTarget don't and shouldn't do anything.

Adding the "then" for the first or the rest of the calls here doesn't do much as
this test particularly relies on those delays in side the test and the main
difference comes from that. I should be able to clean up this automation and
make it similar to others if we get rid of that timeout in w3c test itself. That
should be possible to modify the w3c test to get rid of the timeouts but I
haven't looked at it yet.
It seems that people don't put much time in the reviews of wp tests even though
I pinged them. I guess I need to wait for Rick to come back to do those wpt
changes faster.

+  window.setTimeout(function() {
+    touchScrollInTarget('row1', 'right');
+    window.setTimeout(function() {
+      touchScrollInTarget('cell3', 'down').then(function() {
+        return touchScrollInTarget('cell3', 'right');
+      }).then(function() {
+        touchTapInTarget('btnComplete');
+      });
+    } , 2 * scrollReturnInterval);
+  } , 2 * scrollReturnInterval);
+}