Issue 2252533002: Fix race in GC sweeper and isolate reload rollback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2252533002: Fix race in GC sweeper and isolate reload rollback. (Closed)

Created:
4 years, 4 months ago by Florian Schneider

Modified:
4 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix race in GC sweeper and isolate reload rollback. The sweeper could see a NULL saved_class_table_. Also, make LoadRelaxed a template function to avoid casting to uword. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d664003e5b46c28a48b98ca8932f66bdbd99aeb0

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -12 lines)			Patch
M	runtime/vm/atomic.h	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	runtime/vm/isolate.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate_reload.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 4 months ago (2016-08-15 22:50:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d664003e5b46c28a48b98ca8932f66bdbd99aeb0 (presubmit successful).