Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: runtime/vm/isolate_reload.cc

Issue 2252533002: Fix race in GC sweeper and isolate reload rollback. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate_reload.cc
diff --git a/runtime/vm/isolate_reload.cc b/runtime/vm/isolate_reload.cc
index 81ba9a8009611d4f026b6d8673d657b4457171aa..a00f05e75700ae3baa0892b051a398c71ea9d759 100644
--- a/runtime/vm/isolate_reload.cc
+++ b/runtime/vm/isolate_reload.cc
@@ -1324,10 +1324,11 @@ RawClass* IsolateReloadContext::FindOriginalClass(const Class& cls) {
RawClass* IsolateReloadContext::GetClassForHeapWalkAt(intptr_t cid) {
- if (saved_class_table_ != NULL) {
+ RawClass** class_table = AtomicOperations::LoadRelaxed(&saved_class_table_);
+ if (class_table != NULL) {
ASSERT(cid > 0);
ASSERT(cid < saved_num_cids_);
- return saved_class_table_[cid];
+ return class_table[cid];
} else {
return isolate_->class_table()->At(cid);
}
« no previous file with comments | « runtime/vm/isolate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698