git-cl status: allow querying just the status of current CL

git-cl status: allow querying just the status of current CL

BUG=620494
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/289d03e1c8a859328990899eb8941344192f9ee1

[M-A Ruel, 2016-08-16 15:17:03]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2016-08-16 15:17:03]

lgtm

[Paweł Hajdan Jr., 2016-08-16 15:18:04]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-08-16 15:18:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:21:10]

Description was changed from

==========
git-cl status: allow querying just the status of current CL

BUG=620494
==========

to

==========
git-cl status: allow querying just the status of current CL

BUG=620494

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/289d03e1c8a859...
==========

[commit-bot: I haz the power, 2016-08-16 15:21:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/289d03e1c8a859...

[tandrii(chromium), 2016-08-16 15:24:16]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-08-16 15:24:17]

I don't approve this change because of the intended usage by recipe roller,
which would be broken as soon as someone decides to change output from say
"closed" to "Abandonded(closed)". But this has been discussed in IM with the
author, so I assume that author understands the risks and takes responsibility
for them.

[chromium-reviews, 2016-08-16 15:56:10]

A better way would be to have a --json output format. Haven't we learned
anything about parsing human readable tool outputs? :(

On Tue, Aug 16, 2016, 08:24 <tandrii@chromium.org> wrote:

> I don't approve this change because of the intended usage by recipe roller,
> which would be broken as soon as someone decides to change output from say
> "closed" to "Abandonded(closed)". But this has been discussed in IM with
> the
> author, so I assume that author understands the risks and takes
> responsibility
> for them.
>
> https://codereview.chromium.org/2252473004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Paweł Hajdan Jr., 2016-08-16 15:57:18]

On 2016/08/16 at 15:24:17, tandrii wrote:
> I don't approve this change because of the intended usage by recipe roller,
which would be broken as soon as someone decides to change output from say
"closed" to "Abandonded(closed)". But this has been discussed in IM with the
author, so I assume that author understands the risks and takes responsibility
for them.

I've uploaded https://codereview.chromium.org/2250093002 before landing this.

I interpreted part of our conversation as meaning to go find another reviewer.

FWIW, I totally understand what GetState returns might change.