Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2250093002: git cl: add plumbing command to get metadata about CLs in machine-readable form (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
3 years, 10 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl: add plumbing command to get metadata about CLs in machine-readable form BUG=620494

Patch Set 1 #

Total comments: 3

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -12 lines) Patch
M git_cl.py View 1 7 chunks +82 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tandrii(chromium)
4 years, 4 months ago (2016-08-16 14:52:10 UTC) #2 
SGTM % comment + add a test.

https://codereview.chromium.org/2250093002/diff/1/git_cl.py
File git_cl.py (left):

https://codereview.chromium.org/2250093002/diff/1/git_cl.py#oldcode1687
git_cl.py:1687: if props.get('commit') and not props.get('cq_dry_run', False):
and this is great fix.

https://codereview.chromium.org/2250093002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2250093002/diff/1/git_cl.py#newcode860
git_cl.py:860: ALL_STATES = [NONE, DRY_RUN, COMMIT]
can you make use of these states?

https://codereview.chromium.org/2250093002/diff/1/git_cl.py#newcode1454
git_cl.py:1454: def IsInCQ(self):
s/IsInCQ/GetCQState

and return CQ status from above (see my comment)

Powered by Google App Engine
This is Rietveld 408576698