Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 2252403002: Fix build error. (Closed)

Created:
4 years, 4 months ago by Anton Obzhirov
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build error. in components/os_crypt/key_storage_util_linux.cc:45 error: control reaches end of non-void function BUG= Committed: https://crrev.com/62440fd6ecb0bea661f072d68ee25fc047e8bd72 Cr-Commit-Position: refs/heads/master@{#412928}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/os_crypt/key_storage_util_linux.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Anton Obzhirov
Build error on Ubuntu 14.04, plz have a look.
4 years, 4 months ago (2016-08-18 14:38:09 UTC) #3
Lei Zhang
Are you building with GCC or have some other variation in your build? The code ...
4 years, 4 months ago (2016-08-18 16:52:20 UTC) #4
Anton Obzhirov
On 2016/08/18 16:52:20, Lei Zhang wrote: > Are you building with GCC or have some ...
4 years, 4 months ago (2016-08-18 18:33:18 UTC) #5
Anton Obzhirov
On 2016/08/18 18:33:18, Anton Obzhirov wrote: > On 2016/08/18 16:52:20, Lei Zhang wrote: > > ...
4 years, 4 months ago (2016-08-18 18:42:24 UTC) #6
Lei Zhang
https://codereview.chromium.org/2252403002/diff/1/components/os_crypt/key_storage_util_linux.cc File components/os_crypt/key_storage_util_linux.cc (right): https://codereview.chromium.org/2252403002/diff/1/components/os_crypt/key_storage_util_linux.cc#newcode46 components/os_crypt/key_storage_util_linux.cc:46: return SelectedLinuxBackend::BASIC_TEXT; Can you add a NOTREACHED() before this?
4 years, 4 months ago (2016-08-18 18:44:33 UTC) #7
Lei Zhang
On 2016/08/18 18:42:24, Anton Obzhirov wrote: > On 2016/08/18 18:33:18, Anton Obzhirov wrote: > > ...
4 years, 4 months ago (2016-08-18 18:45:58 UTC) #8
Anton Obzhirov
https://codereview.chromium.org/2252403002/diff/1/components/os_crypt/key_storage_util_linux.cc File components/os_crypt/key_storage_util_linux.cc (right): https://codereview.chromium.org/2252403002/diff/1/components/os_crypt/key_storage_util_linux.cc#newcode46 components/os_crypt/key_storage_util_linux.cc:46: return SelectedLinuxBackend::BASIC_TEXT; On 2016/08/18 18:44:33, Lei Zhang wrote: > ...
4 years, 4 months ago (2016-08-18 19:36:19 UTC) #9
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-18 20:14:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252403002/20001
4 years, 4 months ago (2016-08-18 20:15:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 20:59:14 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 21:01:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62440fd6ecb0bea661f072d68ee25fc047e8bd72
Cr-Commit-Position: refs/heads/master@{#412928}

Powered by Google App Engine
This is Rietveld 408576698