Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2252403002:
Fix build error. (Closed)
|
Created:
4 years, 4 months ago by Anton Obzhirov Modified:
4 years, 4 months ago Reviewers:
Lei Zhang CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix build error.
in components/os_crypt/key_storage_util_linux.cc:45
error: control reaches end of non-void function
BUG=
Committed: https://crrev.com/62440fd6ecb0bea661f072d68ee25fc047e8bd72
Cr-Commit-Position: refs/heads/master@{#412928}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Updated after review #Messages
Total messages: 16 (5 generated)
Description was changed from ========== Fix build error. in components/os_crypt/key_storage_util_linux.cc:45 error: control reaches end of non-void function BUG= ========== to ========== Fix build error. in components/os_crypt/key_storage_util_linux.cc:45 error: control reaches end of non-void function BUG= ==========
a.obzhirov@samsung.com changed reviewers: + thestig@chromium.org
Build error on Ubuntu 14.04, plz have a look.
Are you building with GCC or have some other variation in your build? The code works as is on our build bots.
On 2016/08/18 16:52:20, Lei Zhang wrote: > Are you building with GCC or have some other variation in your build? The code > works as is on our build bots. GCC 4.9
On 2016/08/18 18:33:18, Anton Obzhirov wrote: > On 2016/08/18 16:52:20, Lei Zhang wrote: > > Are you building with GCC or have some other variation in your build? The code > > works as is on our build bots. > > GCC 4.9 But in any case all paths in non void function should return a defined value, shouldn’t it?
https://codereview.chromium.org/2252403002/diff/1/components/os_crypt/key_sto... File components/os_crypt/key_storage_util_linux.cc (right): https://codereview.chromium.org/2252403002/diff/1/components/os_crypt/key_sto... components/os_crypt/key_storage_util_linux.cc:46: return SelectedLinuxBackend::BASIC_TEXT; Can you add a NOTREACHED() before this?
On 2016/08/18 18:42:24, Anton Obzhirov wrote: > On 2016/08/18 18:33:18, Anton Obzhirov wrote: > > On 2016/08/18 16:52:20, Lei Zhang wrote: > > > Are you building with GCC or have some other variation in your build? The > code > > > works as is on our build bots. > > > > GCC 4.9 > > But in any case all paths in non void function should return a defined value, > shouldn’t it? Clang does not seem to care when all the possible enum values have been handled. Though we certainly want this code to build with modern gcc, so I think it's fine.
https://codereview.chromium.org/2252403002/diff/1/components/os_crypt/key_sto... File components/os_crypt/key_storage_util_linux.cc (right): https://codereview.chromium.org/2252403002/diff/1/components/os_crypt/key_sto... components/os_crypt/key_storage_util_linux.cc:46: return SelectedLinuxBackend::BASIC_TEXT; On 2016/08/18 18:44:33, Lei Zhang wrote: > Can you add a NOTREACHED() before this? Done.
The CQ bit was checked by thestig@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix build error. in components/os_crypt/key_storage_util_linux.cc:45 error: control reaches end of non-void function BUG= ========== to ========== Fix build error. in components/os_crypt/key_storage_util_linux.cc:45 error: control reaches end of non-void function BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix build error. in components/os_crypt/key_storage_util_linux.cc:45 error: control reaches end of non-void function BUG= ========== to ========== Fix build error. in components/os_crypt/key_storage_util_linux.cc:45 error: control reaches end of non-void function BUG= Committed: https://crrev.com/62440fd6ecb0bea661f072d68ee25fc047e8bd72 Cr-Commit-Position: refs/heads/master@{#412928} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/62440fd6ecb0bea661f072d68ee25fc047e8bd72 Cr-Commit-Position: refs/heads/master@{#412928} |
