components/os_crypt/key_storage_util_linux.cc - Issue 2252403002: Fix build error.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/os_crypt/key_storage_util_linux.cc

Issue 2252403002: Fix build error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/os_crypt/key_storage_util_linux.h"	5 #include "components/os_crypt/key_storage_util_linux.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8	8

9 namespace os_crypt {	9 namespace os_crypt {

10	10

(...skipping 24 matching lines...) Expand all Loading...
35 return SelectedLinuxBackend::KWALLET5;	35 return SelectedLinuxBackend::KWALLET5;

36 case base::nix::DESKTOP_ENVIRONMENT_GNOME:	36 case base::nix::DESKTOP_ENVIRONMENT_GNOME:

37 case base::nix::DESKTOP_ENVIRONMENT_UNITY:	37 case base::nix::DESKTOP_ENVIRONMENT_UNITY:

38 case base::nix::DESKTOP_ENVIRONMENT_XFCE:	38 case base::nix::DESKTOP_ENVIRONMENT_XFCE:

39 return SelectedLinuxBackend::GNOME_ANY;	39 return SelectedLinuxBackend::GNOME_ANY;

40 // KDE3 didn't use DBus, which our KWallet store uses.	40 // KDE3 didn't use DBus, which our KWallet store uses.

41 case base::nix::DESKTOP_ENVIRONMENT_KDE3:	41 case base::nix::DESKTOP_ENVIRONMENT_KDE3:

42 case base::nix::DESKTOP_ENVIRONMENT_OTHER:	42 case base::nix::DESKTOP_ENVIRONMENT_OTHER:

43 return SelectedLinuxBackend::BASIC_TEXT;	43 return SelectedLinuxBackend::BASIC_TEXT;

44 }	44 }

	45

	46 return SelectedLinuxBackend::BASIC_TEXT;
	Lei Zhang 2016/08/18 18:44:33 Can you add a NOTREACHED() before this? Can you add a NOTREACHED() before this? Anton Obzhirov 2016/08/18 19:36:19 Done. Show quoted text On 2016/08/18 18:44:33, Lei Zhang wrote: > Can you add a NOTREACHED() before this? Done.
45 }	47 }

46	48

47 } // namespace os_crypt	49 } // namespace os_crypt

OLD	NEW