Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 2252373002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
index 3849b7e639e774bb38a3e58b1a4a5cbce845204d..6c9ff477ef1941b77eaf0e6bd5055c5e25675a97 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
@@ -128,8 +128,8 @@ void ExtensionOptionsGuest::DidInitialize(
void ExtensionOptionsGuest::GuestViewDidStopLoading() {
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
- DispatchEventToView(base::WrapUnique(new GuestViewEvent(
- extension_options_internal::OnLoad::kEventName, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ extension_options_internal::OnLoad::kEventName, std::move(args)));
}
const char* ExtensionOptionsGuest::GetAPINamespace() const {
@@ -149,9 +149,9 @@ void ExtensionOptionsGuest::OnPreferredSizeChanged(const gfx::Size& pref_size) {
// Convert the size from physical pixels to logical pixels.
options.width = PhysicalPixelsToLogicalPixels(pref_size.width());
options.height = PhysicalPixelsToLogicalPixels(pref_size.height());
- DispatchEventToView(base::WrapUnique(new GuestViewEvent(
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
extension_options_internal::OnPreferredSizeChanged::kEventName,
- options.ToValue())));
+ options.ToValue()));
}
bool ExtensionOptionsGuest::ShouldHandleFindRequestsForEmbedder() const {
@@ -181,9 +181,9 @@ WebContents* ExtensionOptionsGuest::OpenURLFromTab(
}
void ExtensionOptionsGuest::CloseContents(WebContents* source) {
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(extension_options_internal::OnClose::kEventName,
- base::WrapUnique(new base::DictionaryValue()))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ extension_options_internal::OnClose::kEventName,
+ base::WrapUnique(new base::DictionaryValue())));
}
bool ExtensionOptionsGuest::HandleContextMenu(
« no previous file with comments | « extensions/browser/extension_throttle_manager.cc ('k') | extensions/browser/guest_view/extension_view/extension_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698