Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 2252373002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h" 5 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 const base::DictionaryValue& create_params) { 121 const base::DictionaryValue& create_params) {
122 ExtensionsAPIClient::Get()->AttachWebContentsHelpers(web_contents()); 122 ExtensionsAPIClient::Get()->AttachWebContentsHelpers(web_contents());
123 web_contents()->GetController().LoadURL(options_page_, 123 web_contents()->GetController().LoadURL(options_page_,
124 content::Referrer(), 124 content::Referrer(),
125 ui::PAGE_TRANSITION_LINK, 125 ui::PAGE_TRANSITION_LINK,
126 std::string()); 126 std::string());
127 } 127 }
128 128
129 void ExtensionOptionsGuest::GuestViewDidStopLoading() { 129 void ExtensionOptionsGuest::GuestViewDidStopLoading() {
130 std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue()); 130 std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
131 DispatchEventToView(base::WrapUnique(new GuestViewEvent( 131 DispatchEventToView(base::MakeUnique<GuestViewEvent>(
132 extension_options_internal::OnLoad::kEventName, std::move(args)))); 132 extension_options_internal::OnLoad::kEventName, std::move(args)));
133 } 133 }
134 134
135 const char* ExtensionOptionsGuest::GetAPINamespace() const { 135 const char* ExtensionOptionsGuest::GetAPINamespace() const {
136 return extensionoptions::kAPINamespace; 136 return extensionoptions::kAPINamespace;
137 } 137 }
138 138
139 int ExtensionOptionsGuest::GetTaskPrefix() const { 139 int ExtensionOptionsGuest::GetTaskPrefix() const {
140 return IDS_EXTENSION_TASK_MANAGER_EXTENSIONOPTIONS_TAG_PREFIX; 140 return IDS_EXTENSION_TASK_MANAGER_EXTENSIONOPTIONS_TAG_PREFIX;
141 } 141 }
142 142
143 bool ExtensionOptionsGuest::IsPreferredSizeModeEnabled() const { 143 bool ExtensionOptionsGuest::IsPreferredSizeModeEnabled() const {
144 return true; 144 return true;
145 } 145 }
146 146
147 void ExtensionOptionsGuest::OnPreferredSizeChanged(const gfx::Size& pref_size) { 147 void ExtensionOptionsGuest::OnPreferredSizeChanged(const gfx::Size& pref_size) {
148 extension_options_internal::PreferredSizeChangedOptions options; 148 extension_options_internal::PreferredSizeChangedOptions options;
149 // Convert the size from physical pixels to logical pixels. 149 // Convert the size from physical pixels to logical pixels.
150 options.width = PhysicalPixelsToLogicalPixels(pref_size.width()); 150 options.width = PhysicalPixelsToLogicalPixels(pref_size.width());
151 options.height = PhysicalPixelsToLogicalPixels(pref_size.height()); 151 options.height = PhysicalPixelsToLogicalPixels(pref_size.height());
152 DispatchEventToView(base::WrapUnique(new GuestViewEvent( 152 DispatchEventToView(base::MakeUnique<GuestViewEvent>(
153 extension_options_internal::OnPreferredSizeChanged::kEventName, 153 extension_options_internal::OnPreferredSizeChanged::kEventName,
154 options.ToValue()))); 154 options.ToValue()));
155 } 155 }
156 156
157 bool ExtensionOptionsGuest::ShouldHandleFindRequestsForEmbedder() const { 157 bool ExtensionOptionsGuest::ShouldHandleFindRequestsForEmbedder() const {
158 return true; 158 return true;
159 } 159 }
160 160
161 WebContents* ExtensionOptionsGuest::OpenURLFromTab( 161 WebContents* ExtensionOptionsGuest::OpenURLFromTab(
162 WebContents* source, 162 WebContents* source,
163 const content::OpenURLParams& params) { 163 const content::OpenURLParams& params) {
164 if (!extension_options_guest_delegate_) 164 if (!extension_options_guest_delegate_)
165 return nullptr; 165 return nullptr;
166 166
167 // Don't allow external URLs with the CURRENT_TAB disposition be opened in 167 // Don't allow external URLs with the CURRENT_TAB disposition be opened in
168 // this guest view, change the disposition to NEW_FOREGROUND_TAB. 168 // this guest view, change the disposition to NEW_FOREGROUND_TAB.
169 if ((!params.url.SchemeIs(extensions::kExtensionScheme) || 169 if ((!params.url.SchemeIs(extensions::kExtensionScheme) ||
170 params.url.host() != options_page_.host()) && 170 params.url.host() != options_page_.host()) &&
171 params.disposition == CURRENT_TAB) { 171 params.disposition == CURRENT_TAB) {
172 return extension_options_guest_delegate_->OpenURLInNewTab( 172 return extension_options_guest_delegate_->OpenURLInNewTab(
173 content::OpenURLParams(params.url, 173 content::OpenURLParams(params.url,
174 params.referrer, 174 params.referrer,
175 params.frame_tree_node_id, 175 params.frame_tree_node_id,
176 NEW_FOREGROUND_TAB, 176 NEW_FOREGROUND_TAB,
177 params.transition, 177 params.transition,
178 params.is_renderer_initiated)); 178 params.is_renderer_initiated));
179 } 179 }
180 return extension_options_guest_delegate_->OpenURLInNewTab(params); 180 return extension_options_guest_delegate_->OpenURLInNewTab(params);
181 } 181 }
182 182
183 void ExtensionOptionsGuest::CloseContents(WebContents* source) { 183 void ExtensionOptionsGuest::CloseContents(WebContents* source) {
184 DispatchEventToView(base::WrapUnique( 184 DispatchEventToView(base::MakeUnique<GuestViewEvent>(
185 new GuestViewEvent(extension_options_internal::OnClose::kEventName, 185 extension_options_internal::OnClose::kEventName,
186 base::WrapUnique(new base::DictionaryValue())))); 186 base::WrapUnique(new base::DictionaryValue())));
187 } 187 }
188 188
189 bool ExtensionOptionsGuest::HandleContextMenu( 189 bool ExtensionOptionsGuest::HandleContextMenu(
190 const content::ContextMenuParams& params) { 190 const content::ContextMenuParams& params) {
191 if (!extension_options_guest_delegate_) 191 if (!extension_options_guest_delegate_)
192 return false; 192 return false;
193 193
194 return extension_options_guest_delegate_->HandleContextMenu(params); 194 return extension_options_guest_delegate_->HandleContextMenu(params);
195 } 195 }
196 196
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 SetGuestZoomLevelToMatchEmbedder(); 233 SetGuestZoomLevelToMatchEmbedder();
234 234
235 if (!url::IsSameOriginWith(params.url, options_page_)) { 235 if (!url::IsSameOriginWith(params.url, options_page_)) {
236 bad_message::ReceivedBadMessage(web_contents()->GetRenderProcessHost(), 236 bad_message::ReceivedBadMessage(web_contents()->GetRenderProcessHost(),
237 bad_message::EOG_BAD_ORIGIN); 237 bad_message::EOG_BAD_ORIGIN);
238 } 238 }
239 } 239 }
240 } 240 }
241 241
242 } // namespace extensions 242 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/extension_throttle_manager.cc ('k') | extensions/browser/guest_view/extension_view/extension_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698