components/policy/core/common/registry_dict_win_unittest.cc - Issue 2252353002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/registry_dict_win_unittest.cc

Issue 2252353002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/proxy_policy_provider_unittest.cc ('k') | components/policy/core/common/remote_commands/test_remote_command_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/registry_dict_win_unittest.cc

diff --git a/components/policy/core/common/registry_dict_win_unittest.cc b/components/policy/core/common/registry_dict_win_unittest.cc

index b8fc2157b8858b860b073871adf1ade8eab4b922..ac4d79cc91d0c8d84e128fcd6f94efdf19553d48 100644

--- a/components/policy/core/common/registry_dict_win_unittest.cc

+++ b/components/policy/core/common/registry_dict_win_unittest.cc

@@ -103,7 +103,7 @@ TEST(RegistryDictTest, CaseInsensitiveButPreservingKeyNames) {

base::FundamentalValue int_value(42);

- test_dict.SetKey("One", base::WrapUnique(new RegistryDict()));

+ test_dict.SetKey("One", base::MakeUnique<RegistryDict>());

EXPECT_EQ(1u, test_dict.keys().size());

RegistryDict* actual_subdict = test_dict.GetKey("One");

ASSERT_TRUE(actual_subdict);

@@ -170,7 +170,7 @@ TEST(RegistryDictTest, Swap) {

base::StringValue string_value("fortytwo");

dict_a.SetValue("one", int_value.CreateDeepCopy());

- dict_a.SetKey("two", base::WrapUnique(new RegistryDict()));

+ dict_a.SetKey("two", base::MakeUnique<RegistryDict>());

dict_b.SetValue("three", string_value.CreateDeepCopy());

dict_a.Swap(&dict_b);