components/policy/core/common/proxy_policy_provider_unittest.cc - Issue 2252353002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/proxy_policy_provider_unittest.cc

Issue 2252353002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/preg_parser_win_unittest.cc ('k') | components/policy/core/common/registry_dict_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/proxy_policy_provider_unittest.cc

diff --git a/components/policy/core/common/proxy_policy_provider_unittest.cc b/components/policy/core/common/proxy_policy_provider_unittest.cc

index 6e0749c77a8de93c0457e1ffd0dcc61010f875c1..254074d51cff50d1d819f86649d3d84338e98fbf 100644

--- a/components/policy/core/common/proxy_policy_provider_unittest.cc

+++ b/components/policy/core/common/proxy_policy_provider_unittest.cc

@@ -55,8 +55,8 @@ TEST_F(ProxyPolicyProviderTest, Delegate) {

PolicyBundle bundle;

bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))

.Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::StringValue("value")), nullptr);

+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>("value"),

+ nullptr);

mock_provider_.UpdatePolicy(CopyBundle(bundle));

EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_));

@@ -68,7 +68,7 @@ TEST_F(ProxyPolicyProviderTest, Delegate) {

bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))

.Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::StringValue("new value")), nullptr);

+ base::MakeUnique<base::StringValue>("new value"), nullptr);

mock_provider_.UpdatePolicy(CopyBundle(bundle));

Mock::VerifyAndClearExpectations(&observer_);

EXPECT_TRUE(bundle.Equals(proxy_provider_.policies()));