[turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend if necessary) high…

[turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend if necessary) high 32bit.

We were missing this optimization in a few cases because TruncateInt64ToInt32 was also interfering.
Also removed the equivalent from simplified-lowering.cc, as the arm64 instruction selector has a similar optimization.

R=jarin@chromium.org

Committed: https://crrev.com/06cde13e7cf47adf7c3763d417ce510d3d5fd6f8
Cr-Commit-Position: refs/heads/master@{#38711}

[epertoso, 2016-08-18 09:35:07]

Description was changed from

==========
[turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend
if necessary) high 32bit.

We were missing this optimization in a few cases because TruncateInt64ToInt32
was also interfering.
Also removed the equivalent from simplified-lowering.cc, as the arm64
instruction selector has a similar optimization.

BUG=
==========

to

==========
[turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend
if necessary) high 32bit.

We were missing this optimization in a few cases because TruncateInt64ToInt32
was also interfering.
Also removed the equivalent from simplified-lowering.cc, as the arm64
instruction selector has a similar optimization.

R=jarin@chromium.org
==========

[epertoso, 2016-08-18 09:35:07]

epertoso@chromium.org changed reviewers:
+ jarin@chromium.org

[epertoso, 2016-08-18 09:35:24]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 09:35:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 10:06:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 10:06:53]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-08-18 10:38:17]

lgtm

https://codereview.chromium.org/2252333002/diff/1/src/compiler/x64/instructio...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/2252333002/diff/1/src/compiler/x64/instructio...
src/compiler/x64/instruction-selector-x64.cc:643: static bool
TryMatchLoadWord64AndShiftRight(InstructionSelector* selector,
anonymous namespace?

[epertoso, 2016-08-18 10:51:11]

https://codereview.chromium.org/2252333002/diff/1/src/compiler/x64/instructio...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/2252333002/diff/1/src/compiler/x64/instructio...
src/compiler/x64/instruction-selector-x64.cc:643: static bool
TryMatchLoadWord64AndShiftRight(InstructionSelector* selector,
On 2016/08/18 10:38:16, Jarin wrote:
> anonymous namespace?

Done.

[epertoso, 2016-08-18 10:51:15]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-08-18 10:51:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2252333002/#ps20001
(title: "Update.")

[commit-bot: I haz the power, 2016-08-18 10:51:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 11:24:32]

Description was changed from

==========
[turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend
if necessary) high 32bit.

We were missing this optimization in a few cases because TruncateInt64ToInt32
was also interfering.
Also removed the equivalent from simplified-lowering.cc, as the arm64
instruction selector has a similar optimization.

R=jarin@chromium.org
==========

to

==========
[turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend
if necessary) high 32bit.

We were missing this optimization in a few cases because TruncateInt64ToInt32
was also interfering.
Also removed the equivalent from simplified-lowering.cc, as the arm64
instruction selector has a similar optimization.

R=jarin@chromium.org
==========

[commit-bot: I haz the power, 2016-08-18 11:24:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 11:25:04]

Description was changed from

==========
[turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend
if necessary) high 32bit.

We were missing this optimization in a few cases because TruncateInt64ToInt32
was also interfering.
Also removed the equivalent from simplified-lowering.cc, as the arm64
instruction selector has a similar optimization.

R=jarin@chromium.org
==========

to

==========
[turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend
if necessary) high 32bit.

We were missing this optimization in a few cases because TruncateInt64ToInt32
was also interfering.
Also removed the equivalent from simplified-lowering.cc, as the arm64
instruction selector has a similar optimization.

R=jarin@chromium.org

Committed: https://crrev.com/06cde13e7cf47adf7c3763d417ce510d3d5fd6f8
Cr-Commit-Position: refs/heads/master@{#38711}
==========

[commit-bot: I haz the power, 2016-08-18 11:25:05]

Patchset 2 (id:??) landed as
https://crrev.com/06cde13e7cf47adf7c3763d417ce510d3d5fd6f8
Cr-Commit-Position: refs/heads/master@{#38711}