Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: src/compiler/simplified-lowering.cc

Issue 2252333002: [turbofan/x64] Load word64 followed by a shift right 32 -> load (and sign-extend if necessary) high… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/x64/instruction-selector-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/simplified-lowering.cc
diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc
index dbecd52d3fb95cab59ffa6aa68815812f6efdd8b..cc226447c21542b22e69689c1f119e2410180c6e 100644
--- a/src/compiler/simplified-lowering.cc
+++ b/src/compiler/simplified-lowering.cc
@@ -2189,29 +2189,8 @@ class RepresentationSelector {
FieldAccess access = FieldAccessOf(node->op());
MachineRepresentation const representation =
access.machine_type.representation();
- // If we are loading from a Smi field and truncate the result to Word32,
- // we can instead just load the high word on 64-bit architectures, which
- // is exactly the Word32 we are looking for, and therefore avoid a nasty
- // right shift afterwards.
// TODO(bmeurer): Introduce an appropriate tagged-signed machine rep.
- if (truncation.IsUsedAsWord32() &&
- representation == MachineRepresentation::kTagged &&
- access.type->Is(Type::TaggedSigned()) && SmiValuesAre32Bits()) {
- VisitUnop(node, UseInfoForBasePointer(access),
- MachineRepresentation::kWord32);
- if (lower()) {
- // Morph this Smi load field into an int32 load field.
- access.machine_type = MachineType::Int32();
- access.type = type_cache_.kInt32;
-#if V8_TARGET_LITTLE_ENDIAN
- access.offset += kPointerSize / 2;
-#endif
- NodeProperties::ChangeOp(node,
- jsgraph_->simplified()->LoadField(access));
- }
- } else {
- VisitUnop(node, UseInfoForBasePointer(access), representation);
- }
+ VisitUnop(node, UseInfoForBasePointer(access), representation);
return;
}
case IrOpcode::kStoreField: {
« no previous file with comments | « no previous file | src/compiler/x64/instruction-selector-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698