chrome/test/data/webui/settings/languages_page_browsertest.js - Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods

Patch Set: Reduce diff Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/settings/cr_settings_browsertest.js ('k') | chrome/test/data/webui/settings/languages_page_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/languages_page_browsertest.js

diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js

index dd36cb1fe9e1f6d1707c12d6ecfb060b657290fd..adc2004724c062a50ae11ff51fe2ed6552ef7ede 100644

--- a/chrome/test/data/webui/settings/languages_page_browsertest.js

+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js

@@ -14,8 +14,6 @@ GEN_INCLUDE(

GEN_INCLUDE([ROOT_PATH +

'chrome/test/data/webui/settings/settings_page_browsertest.js']);

-var languageSettings = languageSettings || {};

/**

* Test class for settings-languages-page UI.

* @constructor

@@ -64,7 +62,7 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {

languagesPage = languagesSection.querySelector('settings-languages-page');

assertTrue(!!languagesPage);

- languageHelper = LanguageHelperImpl.getInstance();

+ languageHelper = languagesPage.languageHelper;

return languageHelper.whenReady();

}.bind(this));