Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2088)

Unified Diff: chrome/test/data/webui/settings/languages_page_tests.js

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods
Patch Set: Reduce diff Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/languages_page_tests.js
diff --git a/chrome/test/data/webui/settings/languages_page_tests.js b/chrome/test/data/webui/settings/languages_page_tests.js
deleted file mode 100644
index 068aa1239bdca1f0fe8ce8714f2ac8ca4fc3e3c7..0000000000000000000000000000000000000000
--- a/chrome/test/data/webui/settings/languages_page_tests.js
+++ /dev/null
@@ -1,160 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-cr.define('settings_languages_page', function() {
- suite('settings-languages-singleton', function() {
- var languageSettingsPrivate;
- var languageHelper;
- var settingsPrefs;
- var fakePrefs = [{
- key: 'intl.app_locale',
- type: chrome.settingsPrivate.PrefType.STRING,
- value: 'en-US',
- }, {
- key: 'intl.accept_languages',
- type: chrome.settingsPrivate.PrefType.STRING,
- value: 'en-US,sw',
- }, {
- key: 'spellcheck.dictionaries',
- type: chrome.settingsPrivate.PrefType.LIST,
- value: ['en-US'],
- }, {
- key: 'translate_blocked_languages',
- type: chrome.settingsPrivate.PrefType.LIST,
- value: ['en-US'],
- }];
- if (cr.isChromeOS) {
- fakePrefs.push({
- key: 'settings.language.preferred_languages',
- type: chrome.settingsPrivate.PrefType.STRING,
- value: 'en-US,sw',
- });
- fakePrefs.push({
- key: 'settings.language.preload_engines',
- type: chrome.settingsPrivate.PrefType.STRING,
- value: '_comp_ime_fgoepimhcoialccpbmpnnblemnepkkaoxkb:us::eng,' +
- '_comp_ime_fgoepimhcoialccpbmpnnblemnepkkaoxkb:us:dvorak:eng',
- });
- fakePrefs.push({
- key: 'settings.language.enabled_extension_imes',
- type: chrome.settingsPrivate.PrefType.STRING,
- value: '',
- });
- }
-
- suiteSetup(function() {
- CrSettingsPrefs.deferInitialization = true;
- settingsPrefs = document.createElement('settings-prefs');
- assertTrue(!!settingsPrefs);
- var fakeApi = new settings.FakeSettingsPrivate(fakePrefs);
- settingsPrefs.initializeForTesting(fakeApi);
-
- languageSettingsPrivate = new settings.FakeLanguageSettingsPrivate();
- languageSettings.languageSettingsPrivateApiForTest =
- languageSettingsPrivate;
-
-
- languageSettingsPrivate.setSettingsPrefs(settingsPrefs);
- LanguageHelperImpl.instance_ = undefined;
- languageHelper = LanguageHelperImpl.getInstance();
- return languageHelper.whenReady();
- });
-
- test('languages model', function() {
- for (var i = 0; i < languageSettingsPrivate.languages.length;
- i++) {
- assertEquals(languageSettingsPrivate.languages[i].code,
- languageHelper.languages.supported[i].code);
- }
- assertEquals(2, languageHelper.languages.enabled.length);
- assertEquals('en-US',
- languageHelper.languages.enabled[0].language.code);
- assertEquals('sw',
- languageHelper.languages.enabled[1].language.code);
- assertEquals('en', languageHelper.languages.translateTarget);
-
- // TODO(michaelpg): Test other aspects of the model.
- });
-
- test('modifying languages', function() {
- assertTrue(languageHelper.isLanguageEnabled('en-US'));
- assertTrue(languageHelper.isLanguageEnabled('sw'));
- assertFalse(languageHelper.isLanguageEnabled('en-CA'));
-
- languageHelper.enableLanguage('en-CA');
- assertTrue(languageHelper.isLanguageEnabled('en-CA'));
- languageHelper.disableLanguage('sw');
- assertFalse(languageHelper.isLanguageEnabled('sw'));
-
- // TODO(michaelpg): Test other modifications.
- });
-
- test('reorder languages', function() {
- languageHelper.enableLanguage('sw');
- assertEquals('en-US', languageHelper.languages.enabled[0].language.code);
- assertEquals('en-CA', languageHelper.languages.enabled[1].language.code);
- assertEquals('sw', languageHelper.languages.enabled[2].language.code);
-
- // Can move a language up.
- languageHelper.moveLanguage('sw', -1);
- assertEquals('en-US', languageHelper.languages.enabled[0].language.code);
- assertEquals('sw', languageHelper.languages.enabled[1].language.code);
- assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
-
- // Can move a language down.
- languageHelper.moveLanguage('en-US', 1);
- assertEquals('sw', languageHelper.languages.enabled[0].language.code);
- assertEquals('en-US', languageHelper.languages.enabled[1].language.code);
- assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
-
- // Moving the first language up has no effect.
- languageHelper.moveLanguage('sw', -1);
- assertEquals('sw', languageHelper.languages.enabled[0].language.code);
- assertEquals('en-US', languageHelper.languages.enabled[1].language.code);
- assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
-
- // Moving the last language down has no effect.
- languageHelper.moveLanguage('en-CA', 1);
- assertEquals('sw', languageHelper.languages.enabled[0].language.code);
- assertEquals('en-US', languageHelper.languages.enabled[1].language.code);
- assertEquals('en-CA', languageHelper.languages.enabled[2].language.code);
- });
-
- if (cr.isChromeOS) {
- test('modifying input methods', function() {
- assertEquals(2, languageHelper.languages.inputMethods.enabled.length);
- var inputMethods = languageHelper.getInputMethodsForLanguage('en-US');
- assertEquals(3, inputMethods.length);
-
- // We can remove one input method.
- var dvorak =
- '_comp_ime_fgoepimhcoialccpbmpnnblemnepkkaoxkb:us:dvorak:eng';
- languageHelper.removeInputMethod(dvorak);
- assertEquals(1, languageHelper.languages.inputMethods.enabled.length);
-
- // Enable Swahili.
- languageHelper.enableLanguage('sw');
- assertEquals(1, languageHelper.languages.inputMethods.enabled.length);
-
- // Add input methods for Swahili.
- var sw = '_comp_ime_abcdefghijklmnopqrstuvwxyzabcdefxkb:sw:sw';
- var swUS = '_comp_ime_abcdefghijklmnopqrstuvwxyzabcdefxkb:us:sw';
- languageHelper.addInputMethod(sw);
- languageHelper.addInputMethod(swUS);
- assertEquals(3, languageHelper.languages.inputMethods.enabled.length);
-
- // Disable Swahili. The Swahili-only keyboard should be removed.
- languageHelper.disableLanguage('sw');
- assertEquals(2, languageHelper.languages.inputMethods.enabled.length);
-
- // The US Swahili keyboard should still be enabled, because it supports
- // English which is still enabled.
- assertTrue(languageHelper.languages.inputMethods.enabled.some(
- function(inputMethod) {
- return inputMethod.id == swUS;
- }));
- });
- }
- });
-});
« no previous file with comments | « chrome/test/data/webui/settings/languages_page_browsertest.js ('k') | chrome/test/data/webui/settings/languages_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698