Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 22523003: Enable Google Drive in all save-file dialogs of Chrome OS. (Closed)

Created:
7 years, 4 months ago by kinaba
Modified:
7 years, 4 months ago
Reviewers:
yoshiki, hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Enable Google Drive in all save-file dialogs of Chrome OS. All set. For save dialog called from Drive-unaware code, we provide a local snapshot created by GetFileByPathForSaving so that modification on that file will automatically sync to the remote server. BUG=140425 TEST=Try export from bookmark manager, pixlr.com editor, certificate manager, or about:tracing. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216524

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_util.cc View 1 2 chunks +27 lines, -15 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinaba
This requires https://codereview.chromium.org/22335004/ to land first. +hashimoto: thanks for your review for this series of ...
7 years, 4 months ago (2013-08-08 07:00:32 UTC) #1
yoshiki
Great patch(es)! LGTM!
7 years, 4 months ago (2013-08-08 07:04:19 UTC) #2
hashimoto
lgtm, let's see if the 5-second delay trick would work... https://codereview.chromium.org/22523003/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc File chrome/browser/chromeos/extensions/file_manager/private_api_util.cc (right): https://codereview.chromium.org/22523003/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc#newcode79 ...
7 years, 4 months ago (2013-08-08 07:07:28 UTC) #3
kinaba
https://codereview.chromium.org/22523003/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc File chrome/browser/chromeos/extensions/file_manager/private_api_util.cc (right): https://codereview.chromium.org/22523003/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc#newcode79 chrome/browser/chromeos/extensions/file_manager/private_api_util.cc:79: } else { On 2013/08/08 07:07:28, hashimoto wrote: > ...
7 years, 4 months ago (2013-08-08 08:07:13 UTC) #4
hashimoto
lgtm
7 years, 4 months ago (2013-08-08 08:09:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/22523003/9001
7 years, 4 months ago (2013-08-08 12:06:40 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 01:09:20 UTC) #7
Message was sent while issue was closed.
Change committed as 216524

Powered by Google App Engine
This is Rietveld 408576698