components/autofill/core/common/save_password_progress_logger.h - Issue 2252283005: Introduce password_manager::FormFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.h

Issue 2252283005: Introduce password_manager::FormFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_const_best_matches

Patch Set: Keep updating PasswordStore for blacklisting Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | components/autofill/core/common/save_password_progress_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.h

diff --git a/components/autofill/core/common/save_password_progress_logger.h b/components/autofill/core/common/save_password_progress_logger.h

index 339735f24c00b918daf282d155ff1896f6a445c4..c67a5147d80ae50cbc40fa33199635f799957aec 100644

--- a/components/autofill/core/common/save_password_progress_logger.h

+++ b/components/autofill/core/common/save_password_progress_logger.h

@@ -112,7 +112,7 @@ class SavePasswordProgressLogger {

STRING_WAS_LAST_NAVIGATION_HTTP_ERROR_METHOD,

STRING_HTTP_STATUS_CODE,

STRING_PROVISIONALLY_SAVED_FORM_IS_NOT_HTML,

- STRING_ON_REQUEST_DONE_METHOD,

+ STRING_PROCESS_MATCHES_METHOD,

STRING_BEST_SCORE,

STRING_ON_GET_STORE_RESULTS_METHOD,

STRING_NUMBER_RESULTS,