components/autofill/core/common/save_password_progress_logger.cc - Issue 2252283005: Introduce password_manager::FormFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 2252283005: Introduce password_manager::FormFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_const_best_matches

Patch Set: Keep updating PasswordStore for blacklisting Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 05e8e32c661ba5bf078c4fbce8477bd6202f7fba..0e972f2dce591af3242c7ba751f5f20b7181c86b 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -317,8 +317,8 @@ std::string SavePasswordProgressLogger::GetStringFromID(

case

SavePasswordProgressLogger::STRING_PROVISIONALLY_SAVED_FORM_IS_NOT_HTML:

return "Provisionally saved form is not HTML";

- case SavePasswordProgressLogger::STRING_ON_REQUEST_DONE_METHOD:

- return "PasswordFormManager::OnRequestDone";

+ case SavePasswordProgressLogger::STRING_PROCESS_MATCHES_METHOD:

+ return "PasswordFormManager::ProcessMatches";

case SavePasswordProgressLogger::STRING_BEST_SCORE:

return "best_score";

case SavePasswordProgressLogger::STRING_ON_GET_STORE_RESULTS_METHOD:

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/components_tests.gyp » ('j') | no next file with comments »