Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2252223002: Introduce ModuleScope subclass of DeclarationScope (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis, adamk, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce ModuleScope subclass of DeclarationScope This moves the module_descriptor_ field to that subclass, as well as other module-only methods. BUG=v8:5209 Committed: https://crrev.com/4484bb41b5be21f6c6f072aeac0f1370ec162312 Cr-Commit-Position: refs/heads/master@{#38703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -40 lines) Patch
M src/ast/modules.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/modules.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ast/scopes.h View 6 chunks +28 lines, -19 lines 0 comments Download
M src/ast/scopes.cc View 5 chunks +20 lines, -7 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/parsing/parser-base.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-17 21:59:01 UTC) #2
neis
lgtm lgtm.
4 years, 4 months ago (2016-08-18 08:08:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252223002/1
4 years, 4 months ago (2016-08-18 08:15:59 UTC) #9
Toon Verwaest
@marja: ptal parser
4 years, 4 months ago (2016-08-18 08:17:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21986)
4 years, 4 months ago (2016-08-18 08:20:48 UTC) #13
marja
lgtm
4 years, 4 months ago (2016-08-18 08:43:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252223002/1
4 years, 4 months ago (2016-08-18 08:49:20 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:50:59 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:51:09 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4484bb41b5be21f6c6f072aeac0f1370ec162312
Cr-Commit-Position: refs/heads/master@{#38703}

Powered by Google App Engine
This is Rietveld 408576698