src/ast/modules.cc - Issue 2252223002: Introduce ModuleScope subclass of DeclarationScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/modules.cc

Issue 2252223002: Introduce ModuleScope subclass of DeclarationScope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/modules.cc

diff --git a/src/ast/modules.cc b/src/ast/modules.cc

index a5ef69e1bbfdb6a45a86d14680ffcb3b336b26b1..cd47c00b92971ab9a583e91de51913b3768ade31 100644

--- a/src/ast/modules.cc

+++ b/src/ast/modules.cc

@@ -97,10 +97,9 @@ void ModuleDescriptor::MakeIndirectExportsExplicit() {

}

-bool ModuleDescriptor::Validate(DeclarationScope* module_scope,

+bool ModuleDescriptor::Validate(ModuleScope* module_scope,

PendingCompilationErrorHandler* error_handler,

Zone* zone) {

- DCHECK(module_scope->is_module_scope());

DCHECK_EQ(this, module_scope->module());

DCHECK_NOT_NULL(error_handler);

« no previous file with comments | « src/ast/modules.h ('k') | src/ast/scopes.h » ('j') | no next file with comments »