ui/webui/resources/webui_resources.grd - Issue 2252063002: Adding client code for new desktop First Run Experience.

Unified Diff: ui/webui/resources/webui_resources.grd

Issue 2252063002: Adding client code for new desktop First Run Experience. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing spacing nits before review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/webui_resources.grd

diff --git a/ui/webui/resources/webui_resources.grd b/ui/webui/resources/webui_resources.grd

index 34e3ba808701cf20c3e404af0101d0019f188992..16c90e21cd6db8775249ad16b2c9e78196891569 100644

--- a/ui/webui/resources/webui_resources.grd

+++ b/ui/webui/resources/webui_resources.grd

@@ -186,6 +186,8 @@ without changes to the corresponding grd file. -->

file="images/disabled_select.png" type="BINDATA" />

<include name="IDR_WEBUI_IMAGES_ERROR"

file="images/error.svg" type="BINDATA" />

+ <include name="IDR_WEBUI_IMAGES_GOOGLE_LOGO"

+ file="images/google_logo.svg" type="BINDATA" />

Moe 2016/08/19 17:10:52 This should probably be 'product_logo.svg'

tmartino 2016/08/19 20:11:29 Hmm? That's a different image. This is for a Googl

Moe 2016/08/19 20:40:52 does the FRE in chromium also use the Google wordm

tmartino 2016/08/19 22:03:16 Yes, it does. Incidentally, the svg file is alread

Moe 2016/08/22 20:40:51 Acknowledged.

<include name="IDR_WEBUI_IMAGES_SELECT"

file="images/select.png" type="BINDATA" />

<include name="IDR_WEBUI_IMAGES_THROBBER_MEDIUM"

« chrome/browser/resources/welcome/welcome.html ('K') | « chrome/common/url_constants.cc ('k') | no next file » | no next file with comments »