Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: ui/webui/resources/webui_resources.grd

Issue 2252063002: Adding client code for new desktop First Run Experience. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing spacing nits before review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!-- This comment is only here because changes to resources are not picked up 2 <!-- This comment is only here because changes to resources are not picked up
3 without changes to the corresponding grd file. --> 3 without changes to the corresponding grd file. -->
4 <grit latest_public_release="0" current_release="1" output_all_resource_defines= "false"> 4 <grit latest_public_release="0" current_release="1" output_all_resource_defines= "false">
5 <outputs> 5 <outputs>
6 <output filename="grit/webui_resources.h" type="rc_header"> 6 <output filename="grit/webui_resources.h" type="rc_header">
7 <emit emit_type='prepend'></emit> 7 <emit emit_type='prepend'></emit>
8 </output> 8 </output>
9 <output filename="grit/webui_resources_map.cc" 9 <output filename="grit/webui_resources_map.cc"
10 type="resource_file_map_source" /> 10 type="resource_file_map_source" />
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 <include name="IDR_WEBUI_IMAGES_CHECK" 179 <include name="IDR_WEBUI_IMAGES_CHECK"
180 file="images/check.png" type="BINDATA" /> 180 file="images/check.png" type="BINDATA" />
181 <include name="IDR_WEBUI_IMAGES_CHECKBOX_BLACK" 181 <include name="IDR_WEBUI_IMAGES_CHECKBOX_BLACK"
182 file="images/checkbox_black.png" type="BINDATA" /> 182 file="images/checkbox_black.png" type="BINDATA" />
183 <include name="IDR_WEBUI_IMAGES_CHECKBOX_WHITE" 183 <include name="IDR_WEBUI_IMAGES_CHECKBOX_WHITE"
184 file="images/checkbox_white.png" type="BINDATA" /> 184 file="images/checkbox_white.png" type="BINDATA" />
185 <include name="IDR_WEBUI_IMAGES_DISABLED_SELECT" 185 <include name="IDR_WEBUI_IMAGES_DISABLED_SELECT"
186 file="images/disabled_select.png" type="BINDATA" /> 186 file="images/disabled_select.png" type="BINDATA" />
187 <include name="IDR_WEBUI_IMAGES_ERROR" 187 <include name="IDR_WEBUI_IMAGES_ERROR"
188 file="images/error.svg" type="BINDATA" /> 188 file="images/error.svg" type="BINDATA" />
189 <include name="IDR_WEBUI_IMAGES_GOOGLE_LOGO"
190 file="images/google_logo.svg" type="BINDATA" />
Moe 2016/08/19 17:10:52 This should probably be 'product_logo.svg'
tmartino 2016/08/19 20:11:29 Hmm? That's a different image. This is for a Googl
Moe 2016/08/19 20:40:52 does the FRE in chromium also use the Google wordm
tmartino 2016/08/19 22:03:16 Yes, it does. Incidentally, the svg file is alread
Moe 2016/08/22 20:40:51 Acknowledged.
189 <include name="IDR_WEBUI_IMAGES_SELECT" 191 <include name="IDR_WEBUI_IMAGES_SELECT"
190 file="images/select.png" type="BINDATA" /> 192 file="images/select.png" type="BINDATA" />
191 <include name="IDR_WEBUI_IMAGES_THROBBER_MEDIUM" 193 <include name="IDR_WEBUI_IMAGES_THROBBER_MEDIUM"
192 file="images/throbber_medium.svg" type="BINDATA" /> 194 file="images/throbber_medium.svg" type="BINDATA" />
193 <include name="IDR_WEBUI_IMAGES_THROBBER_SMALL" 195 <include name="IDR_WEBUI_IMAGES_THROBBER_SMALL"
194 file="images/throbber_small.svg" type="BINDATA" /> 196 file="images/throbber_small.svg" type="BINDATA" />
195 <include name="IDR_WEBUI_IMAGES_TRASH" 197 <include name="IDR_WEBUI_IMAGES_TRASH"
196 file="images/trash.png" type="BINDATA" /> 198 file="images/trash.png" type="BINDATA" />
197 199
198 <if expr="chromeos"> 200 <if expr="chromeos">
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 file="js/chromeos/ui_account_tweaks.js" 468 file="js/chromeos/ui_account_tweaks.js"
467 type="chrome_html" /> 469 type="chrome_html" />
468 </if> 470 </if>
469 <part file="cr_elements_resources.grdp" /> 471 <part file="cr_elements_resources.grdp" />
470 <if expr="not is_android"> 472 <if expr="not is_android">
471 <part file="polymer_resources.grdp" /> 473 <part file="polymer_resources.grdp" />
472 </if> 474 </if>
473 </structures> 475 </structures>
474 </release> 476 </release>
475 </grit> 477 </grit>
OLDNEW
« chrome/browser/resources/welcome/welcome.html ('K') | « chrome/common/url_constants.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698