chrome/app/chromium_strings.grd - Issue 2252063002: Adding client code for new desktop First Run Experience.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chromium_strings.grd

Issue 2252063002: Adding client code for new desktop First Run Experience. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing build issues after rebasing Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chromium_strings.grd

diff --git a/chrome/app/chromium_strings.grd b/chrome/app/chromium_strings.grd

index 925b598cdbae91ebd16c3d977c34657056b2e28c..fb72147e029f8019558770bab52684917705d28f 100644

--- a/chrome/app/chromium_strings.grd

+++ b/chrome/app/chromium_strings.grd

@@ -1261,6 +1261,14 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@example.com</

</message>

</if>

+

michaelpg 2016/09/06 22:21:56 all resources in this CL: wrap in <if expr="not ch

tmartino 2016/09/07 23:06:42 Done

+ <message name="IDS_WELCOME_UI_WELCOME_HEADER" desc="A message which will appear as the header on the Welcome UI if the user has never run Chromium before.">

michaelpg 2016/09/06 22:21:56 <bikeshed> We almost never use "_UI_" in string n

tmartino 2016/09/07 23:06:42 Done

+ Welcome to Chromium

+ </message>

+ <message name="IDS_WELCOME_UI_EVERYWHERE_HEADER" desc="A message which will appear as the header on the Welcome UI if the user has run Chromium before.">

+ Take Chromium everywhere

+ </message>

</messages>

</release>

</grit>

« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/browser/resources/welcome/welcome.html » ('J')